Merge remote-tracking branch 'benma/remove-device-tests'

Author: benma

.ci/ci

@@ -56,9 +56,6 @@ make -j8 firmware-semihosting
 
 make -C tools/go/src/atecc608a test
 
-# Build device tests
-make -j8 device-tests
-
 # Don't generate graphics in CI
 (cd build; cmake -DDOC_GRAPHS=NO ..)
 make -j8 docs

BUILD.md

@@ -186,75 +186,3 @@ make coverage # or make -C build-build coverage
 ```sh
 make -C build-build coverage-lcovr
 ```
-
-### Device tests
-
-If you have a developer device at hand you can run device tests on it. Device tests help to verify functionality on an actual device.
-Feedback can be provided via the screen or via USB. They are especially useful to test low-level, driver-specific features.
-
-Device tests replace the source file where the main function resides, but otherwise have access to all firmware functions.
-
-#### Code and build structure
-
-The python scripts for setting up and running the test can be found under `test/device-test`. Firmware test code can be found
-under `test/device-test/src`. `test/device-test/src/common` contains common C code functions that many test cases might need.
-
-The object and binary files are built into `test/device-test/build`.
-
-#### How to set up a test
-
-The `test/device-test/setup_test.py` script assists you in building the binary with a given test case, flashing the device
-with the resulting `device-test.bin` that gets built into `test/device-test/build/bin` and resetting the device so that the test is started.
-
-You can run `setup_test.py` as follows:
-
-```sh
-./test/device-test/setup_test.py -t test/device-test/src/startup_test.c
-```
-
-If you run it successfully, the device should print `Integration test` on the screen.
-
-#### How to write a test
-
-The test becomes more interesting as we add the ability to function in a python script.
-Here is an example for a python test:
-
-```python
-#!/usr/bin/env python
-
-from setup_test import *
-import sys
-import time
-
-# required to find py/dbb_utils.py
-test_dir = os.path.dirname(os.path.realpath(__file__))
-sys.path.insert(0, test_dir + '/../py/')
-
-from dbb_utils import *
-
-def main(argv):
-    test = "src/test_usb_hww_ep_in.c"
-    setup(argv, test)
-    run_test(test)
-
-def run_test(testfile):
-    print("execute testcase for " + testfile)
-    print("expecting 'Hi HWW!' as a reply")
-
-    try:
-        openSpecificHid(USB_HWW)
-        time.sleep(5)
-        reply = hid_send_and_read_plain('Hi HWW!', 5)
-
-    except IOError as ex:
-        print(ex)
-    except(KeyboardInterrupt, SystemExit):
-        print("Exiting code")
-    dbb_hid.close()
-
-if __name__ == "__main__":
-    main(sys.argv[1:])
-```
-
-The test passes the C test file to `setup()`. Afterwards it executed `run_test()`.
-In `run_test`, it opens the HID interface `HWW` and sends some data over USB.

CMakeLists.txt

@@ -411,10 +411,6 @@ endif()
 
 if(CMAKE_CROSSCOMPILING)
   add_dependencies(doc rust-docs)
-endif()
-
-if(CMAKE_CROSSCOMPILING)
-  add_subdirectory(test/device-test)
 else()
   include(CTest)
   add_subdirectory(test/unit-test)

Makefile

@@ -96,8 +96,6 @@ rust-docs: | build
 	$(MAKE) -C build rust-docs
 unit-test: | build-build
 	$(MAKE) -C build-build
-device-tests: | build
-	${MAKE} -C build device-tests
 # Must compile C tests before running them
 run-unit-tests: | build-build
 	CTEST_OUTPUT_ON_FAILURE=1 $(MAKE) -C build-build test

src/CMakeLists.txt

@@ -544,13 +544,6 @@ foreach(type ${RUST_LIBS})
       # https://github.com/rust-lang/rust/issues/66740
       RUSTC_BOOTSTRAP=1
       ${CARGO} build $<$<BOOL:${CMAKE_VERBOSE_MAKEFILE}>:-v> --features target-${type} --target-dir ${RUST_BINARY_DIR}/feature-${type} ${RUST_CARGO_FLAG} ${RUST_TARGET_ARCH_ARG}
-    COMMAND
-      # Rust packages stdlib functions which we must remove/weaken on the arm target
-      # Currently the removed symbols only clash in device-tests for some reason. Without this command, compiling device tests would result in errors like:
-      # Linking C executable ../../bin/fw_test_usb_cmd_process.elf
-      # /usr/local/bin/../lib/gcc/arm-none-eabi/8.2.1/../../../../arm-none-eabi/bin/ld: /usr/local/bin/../lib/gcc/arm-none-eabi/8.2.1/thumb/v7e-m+fp/softfp/libgcc.a(_arm_addsubdf3.o): in function `__aeabi_dsub':
-      # (.text+0x8): multiple definition of `__aeabi_dsub'; ../../lib/libfirmware_rust_c.a(compiler_builtins-5829be534503bd8e.compiler_builtins.cthmhl66-cgu.175.rcgu.o):/cargo/registry/src/github.com-1ecc6299db9ec823/compiler_builtins-0.1.27/src/macros.rs:226: first defined here
-      if test "x${RUST_TARGET_ARCH}" = "xthumbv7em-none-eabi" \; then ${CMAKE_OBJCOPY} -W __aeabi_dsub -W __aeabi_dadd -W__aeabi_i2d -W __aeabi_f2d -W __aeabi_dmul -W __aeabi_ul2d ${lib} \; fi
     COMMAND
       ${CMAKE_COMMAND} -E copy_if_different ${lib} ${CMAKE_ARCHIVE_OUTPUT_DIRECTORY}/lib${type}_rust_c.a
     # DEPFILES are only supported with the Ninja build tool