Merge branch 'offlineQt'

bznein · bznein · commit f4d476926f09 · 2025-06-30T14:46:18.000+02:00
diff --git a/backend/backend.go b/backend/backend.go
@@ -24,6 +24,7 @@ import (
 	"path/filepath"
 	"slices"
 	"strings"
+	"sync/atomic"
 	"time"
 
 	"github.com/BitBoxSwiss/bitbox-wallet-app/backend/accounts"
@@ -235,6 +236,9 @@ type Backend struct {
 
 	// testing tells us whether the app is in testing mode
 	testing bool
+
+	// isOnline indicates whether the backend is online, i.e. able to connect to the internet.
+	isOnline atomic.Bool
 }
 
 // NewBackend creates a new backend with the given arguments.
@@ -276,6 +280,8 @@ func NewBackend(arguments *arguments.Arguments, environment Environment) (*Backe
 
 		testing: backendConfig.AppConfig().Backend.StartInTestnet || arguments.Testing(),
 	}
+	// TODO: remove when connectivity check is present on all platforms
+	backend.isOnline.Store(true)
 
 	notifier, err := NewNotifier(filepath.Join(arguments.MainDirectoryPath(), "notifier.db"))
 	if err != nil {
@@ -549,7 +555,7 @@ func (backend *Backend) Coin(code coinpkg.Code) (coinpkg.Coin, error) {
 // ManualReconnect triggers reconnecting to Electrum servers if their connection is down.
 // Only coin connections that were previously established are reconnected.
 // Calling this is a no-op for coins that are already connected.
-func (backend *Backend) ManualReconnect() {
+func (backend *Backend) ManualReconnect(reconnectETH bool) {
 	var electrumCoinCodes []coinpkg.Code
 	if backend.Testing() {
 		electrumCoinCodes = []coinpkg.Code{
@@ -581,6 +587,16 @@ func (backend *Backend) ManualReconnect() {
 		}
 		blockchain.ManualReconnect()
 	}
+	if reconnectETH {
+		backend.log.Info("Reconnecting ETH accounts")
+		for _, account := range backend.accounts {
+			ethAccount, ok := account.(*eth.Account)
+			if !ok {
+				continue
+			}
+			ethAccount.EnqueueUpdate()
+		}
+	}
 }
 
 // Testing returns whether this backend is for testing only.
@@ -943,6 +959,26 @@ func (backend *Backend) HandleURI(uri string) {
 	}
 }
 
+// SetOnline sets the backend's online status and notifies the frontend.
+func (backend *Backend) SetOnline(online bool) {
+	backend.log.Infof("Setting online status to %v", online)
+	// If coming back online, trigger a reconnection.
+	if online && !backend.isOnline.Load() {
+		backend.ManualReconnect(true)
+	}
+	backend.isOnline.Store(online)
+	backend.Notify(observable.Event{
+		Subject: "online",
+		Action:  action.Reload,
+		Object:  online,
+	})
+}
+
+// IsOnline returns whether the backend is online, i.e. able to connect to the internet.
+func (backend *Backend) IsOnline() bool {
+	return backend.isOnline.Load()
+}
+
 // GetAccountFromCode takes an account code as input and returns the corresponding accounts.Interface object,
 // if found. It also initialize the account before returning it.
 func (backend *Backend) GetAccountFromCode(acctCode accountsTypes.Code) (accounts.Interface, error) {
diff --git a/backend/bridgecommon/bridgecommon.go b/backend/bridgecommon/bridgecommon.go
@@ -123,6 +123,16 @@ func HandleURI(uri string) {
 	globalBackend.HandleURI(uri)
 }
 
+// SetOnline should be called when the network connection changed.
+func SetOnline(isOnline bool) {
+	mu.RLock()
+	defer mu.RUnlock()
+	if globalBackend == nil {
+		return
+	}
+	globalBackend.SetOnline(isOnline)
+}
+
 // TriggerAuth triggers an authentication request notification.
 func TriggerAuth() {
 	mu.Lock()
@@ -176,7 +186,9 @@ func ManualReconnect() {
 	if globalBackend == nil {
 		return
 	}
-	globalBackend.ManualReconnect()
+	// We pass false as by default we do not want
+	// to reconnect ETH accounts.
+	globalBackend.ManualReconnect(false)
 
 }
 
diff --git a/backend/coins/eth/account.go b/backend/coins/eth/account.go
@@ -714,7 +714,7 @@ func (account *Account) SendTx(txNote string) error {
 		// Not critical.
 		account.log.WithError(err).Error("Failed to save transaction note when sending a tx")
 	}
-	account.enqueueUpdateCh <- struct{}{}
+	account.EnqueueUpdate()
 	return nil
 }
 
@@ -1024,3 +1024,11 @@ func (account *Account) MatchesAddress(address string) (bool, error) {
 	}
 	return false, nil
 }
+
+// EnqueueUpdate enqueues an update for the account.
+func (account *Account) EnqueueUpdate() {
+	select {
+	case account.enqueueUpdateCh <- struct{}{}:
+	default:
+	}
+}
diff --git a/backend/handlers/handlers.go b/backend/handlers/handlers.go
@@ -116,6 +116,7 @@ type Backend interface {
 	SetWatchonly(rootFingerprint []byte, watchonly bool) error
 	LookupEthAccountCode(address string) (accountsTypes.Code, string, error)
 	Bluetooth() *bluetooth.Bluetooth
+	IsOnline() bool
 }
 
 // Handlers provides a web api to the backend.
@@ -262,6 +263,8 @@ func NewHandlers(
 	getAPIRouterNoError(apiRouter)("/bluetooth/state", handlers.getBluetoothState).Methods("GET")
 	getAPIRouterNoError(apiRouter)("/bluetooth/connect", handlers.postBluetoothConnect).Methods("POST")
 
+	getAPIRouterNoError(apiRouter)("/online", handlers.getOnline).Methods("GET")
+
 	devicesRouter := getAPIRouterNoError(apiRouter.PathPrefix("/devices").Subrouter())
 	devicesRouter("/registered", handlers.getDevicesRegistered).Methods("GET")
 
@@ -1622,3 +1625,7 @@ func (handlers *Handlers) postBluetoothConnect(r *http.Request) interface{} {
 	handlers.backend.Environment().BluetoothConnect(identifier)
 	return nil
 }
+
+func (handlers *Handlers) getOnline(r *http.Request) interface{} {
+	return handlers.backend.IsOnline()
+}
diff --git a/frontends/qt/BitBox.pro b/frontends/qt/BitBox.pro
@@ -6,6 +6,7 @@
 
 QT       += core gui
 QT       += webenginewidgets
+QT       += network
 win32 {
     # For setting 'AlwaysActivate', see.
     # See https://forum.qt.io/topic/133694/using-alwaysactivatewindow-to-gain-foreground-in-win10-using-qt6-2/2
@@ -60,9 +61,10 @@ unix:!macx {
 SOURCES += \
         main.cpp \
         filedialog.cpp \
-        urlhandler.cpp
+        urlhandler.cpp \
+        network.cpp
 
-HEADERS += libserver.h webclass.h filedialog.h urlhandler.h
+HEADERS += libserver.h webclass.h filedialog.h urlhandler.h network.h
 
 unix:macx {
     CONFIG += sdk_no_version_check
diff --git a/frontends/qt/libserver.h b/frontends/qt/libserver.h
@@ -3,6 +3,7 @@
 #include <string.h>
 #include <stdint.h>
 #include <stdlib.h>
+#include <stdbool.h>
 
 // Workaround to be able to use `const char*` as a param type in the exported Go functions.
 typedef const char cchar_t;
@@ -45,6 +46,7 @@ extern "C" {
 #endif
 
 extern void backendCall(int queryID, cchar_t* s);
+extern void setOnline(bool online);
 extern void handleURI(cchar_t* uri);
 extern void serve(cppHeapFree cppHeapFreeFn, pushNotificationsCallback pushNotificationsFn, responseCallback responseFn, notifyUserCallback notifyUserFn, cchar_t* preferredLocale, getSaveFilenameCallback getSaveFilenameFn);
 extern void systemOpen(cchar_t* url);
diff --git a/frontends/qt/main.cpp b/frontends/qt/main.cpp
@@ -57,6 +57,7 @@
 #include "libserver.h"
 #include "webclass.h"
 #include "urlhandler.h"
+#include "network.h"
 
 #define APPNAME "BitBoxApp"
 
@@ -371,6 +372,8 @@ int main(int argc, char *argv[])
 
     webClass = new WebClass();
 
+    setupReachabilityNotifier();
+
     serve(
         // cppHeapFree
         [](void* ptr) { ::free(ptr); },
@@ -417,6 +420,9 @@ int main(int argc, char *argv[])
             return result;
         });
 
+    // Trigger the online status change event once at startup.
+    setOnline(isReachable());
+
     RequestInterceptor interceptor;
     view->page()->profile()->setUrlRequestInterceptor(&interceptor);
 
diff --git a/frontends/qt/network.cpp b/frontends/qt/network.cpp
@@ -0,0 +1,36 @@
+#include <QNetworkInformation>
+#include "libserver.h"
+#include "network.h"
+
+void setupReachabilityNotifier() {
+    auto loaded = QNetworkInformation::loadBackendByFeatures(QNetworkInformation::Feature::Reachability);
+    if (!loaded) {
+        goLog("can't load QNetworkInformation backend");
+        // If we can't load the backend, we can't determine whether or not to show the banner.
+        setOnline(true);
+        return;
+    }
+    QNetworkInformation* info = QNetworkInformation::instance();
+    if (info) {
+      QObject::connect(info, &QNetworkInformation::reachabilityChanged, [](QNetworkInformation::Reachability reachability){
+          // We include Reachability::Unknown here as we prefer not include false positives. If QT can't determine whether
+          // we are online, we do not show the banner.
+          bool isReachable = (reachability == QNetworkInformation::Reachability::Online || reachability == QNetworkInformation::Reachability::Unknown);
+          setOnline(isReachable);
+      });
+    }
+}
+
+bool isReachable() {
+    auto loaded = QNetworkInformation::loadBackendByFeatures(QNetworkInformation::Feature::Reachability);
+    if (!loaded) {
+        goLog("can't load QNetworkInformation backend");
+        return true;
+    }
+    QNetworkInformation* info = QNetworkInformation::instance();
+    if (info) {
+        return info->reachability() == QNetworkInformation::Reachability::Online || info->reachability() == QNetworkInformation::Reachability::Unknown;
+    }
+    // Same as above, if we can't obtain information, we don't show any banner at all.
+    return true;
+}
diff --git a/frontends/qt/network.h b/frontends/qt/network.h
@@ -0,0 +1,12 @@
+#ifndef NETWORK_H
+#define NETWORK_H
+#include <stdbool.h>
+
+// setupReachabilityNotifier connects to the QNetworkInformation::reachabilityChanged signal
+// in otder to react to changes in reachability.
+void setupReachabilityNotifier();
+// isReachable uses QNetworkInformation to retrieve info about the online status.
+// Note: it treats cases in which QT can't determine if we are online as if we were.
+bool isReachable();
+
+#endif // NETWORK_H
diff --git a/frontends/qt/server/server.go b/frontends/qt/server/server.go
@@ -103,6 +103,11 @@ func matchDarkTheme(themeName string) bool {
 	return strings.Contains(strings.ToLower(themeName), "dark")
 }
 
+//export setOnline
+func setOnline(isReachable bool) {
+	bridgecommon.SetOnline(isReachable)
+}
+
 //export serve
 func serve(
 	cppHeapFreeFn C.cppHeapFree,
diff --git a/frontends/web/src/api/online.ts b/frontends/web/src/api/online.ts
@@ -0,0 +1,28 @@
+/**
+ * Copyright 2025 Shift Crypto AG
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { apiGet } from '@/utils/request';
+import { subscribeEndpoint, TSubscriptionCallback } from './subscribe';
+
+export const getOnline = (): Promise<boolean> => {
+  return apiGet('online');
+};
+
+export const subscribeOnline = (
+  cb: TSubscriptionCallback<boolean>
+) => (
+  subscribeEndpoint('online', cb)
+);
diff --git a/frontends/web/src/components/banners/index.tsx b/frontends/web/src/components/banners/index.tsx
@@ -18,6 +18,7 @@ import { Testing } from './testing';
 import { Update } from './update';
 import { Banner } from './banner';
 import { MobileDataWarning } from './mobiledatawarning';
+import { Offline } from './offline';
 
 export const GlobalBanners = () => {
   return (
@@ -27,6 +28,7 @@ export const GlobalBanners = () => {
       <Banner msgKey="bitbox01" />
       <Banner msgKey="bitbox02" />
       <MobileDataWarning />
+      <Offline />
     </>
   );
 };
diff --git a/frontends/web/src/components/banners/offline.tsx b/frontends/web/src/components/banners/offline.tsx
@@ -0,0 +1,35 @@
+/**
+ * Copyright 2025 Shift Crypto AG
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { useTranslation } from 'react-i18next';
+import { Status } from '@/components/status/status';
+import { AppContext } from '@/contexts/AppContext';
+import { useContext } from 'react';
+
+export const Offline = () => {
+  const { t } = useTranslation();
+  const { isOnline } = useContext(AppContext);
+
+  if (isOnline === undefined) {
+    return null;
+  }
+
+  return (
+    <Status type="warning"
+      hidden={isOnline}>
+      {t('warning.offline')}
+    </Status>
+  );
+};
diff --git a/frontends/web/src/contexts/AppContext.tsx b/frontends/web/src/contexts/AppContext.tsx
@@ -25,6 +25,7 @@ type AppContextProps = {
     hideAmounts: boolean;
     isTesting: boolean;
     isDevServers: boolean;
+    isOnline?: boolean;
     nativeLocale: string;
     firmwareUpdateDialogOpen: boolean;
     chartDisplay: TChartDisplay;
diff --git a/frontends/web/src/contexts/AppProvider.tsx b/frontends/web/src/contexts/AppProvider.tsx
@@ -21,10 +21,12 @@ import { useLoad } from '@/hooks/api';
 import { useDefault } from '@/hooks/default';
 import { getNativeLocale } from '@/api/nativelocale';
 import { getDevServers, getTesting } from '@/api/backend';
+import { getOnline, subscribeOnline } from '@/api/online';
 import { i18nextFormat } from '@/i18n/utils';
 import type { TChartDisplay } from './AppContext';
 import { useOrientation } from '@/hooks/orientation';
 import { useMediaQuery } from '@/hooks/mediaquery';
+import { useSync } from '@/hooks/api';
 
 type TProps = {
     children: ReactNode;
@@ -33,6 +35,7 @@ type TProps = {
 export const AppProvider = ({ children }: TProps) => {
   const nativeLocale = i18nextFormat(useDefault(useLoad(getNativeLocale), 'de-CH'));
   const isTesting = useDefault(useLoad(getTesting), false);
+  const isOnline = useSync(getOnline, subscribeOnline);
   const isDevServers = useDefault(useLoad(getDevServers), false);
   const [guideShown, setGuideShown] = useState(false);
   const [guideExists, setGuideExists] = useState(false);
@@ -89,6 +92,7 @@ export const AppProvider = ({ children }: TProps) => {
         hideAmounts,
         isTesting,
         isDevServers,
+        isOnline,
         nativeLocale,
         chartDisplay,
         setActiveSidebar,
diff --git a/frontends/web/src/locales/en/app.json b/frontends/web/src/locales/en/app.json

Original file line number	Diff line number	Diff line change
`@@ -714,7 +714,7 @@ func (account *Account) SendTx(txNote string) error {`
`714`	`714`	`// Not critical.`
`715`	`715`	`account.log.WithError(err).Error("Failed to save transaction note when sending a tx")`
`716`	`716`	`}`
`717`		`- account.enqueueUpdateCh <- struct{}{}`
	`717`	`+ account.EnqueueUpdate()`
`718`	`718`	`return nil`
`719`	`719`	`}`
`720`	`720`
`@@ -1024,3 +1024,11 @@ func (account *Account) MatchesAddress(address string) (bool, error) {`
`1024`	`1024`	`}`
`1025`	`1025`	`return false, nil`
`1026`	`1026`	`}`
	`1027`	`+`
	`1028`	`+// EnqueueUpdate enqueues an update for the account.`
	`1029`	`+func (account *Account) EnqueueUpdate() {`
	`1030`	`+ select {`
	`1031`	`+ case account.enqueueUpdateCh <- struct{}{}:`
	`1032`	`+ default:`
	`1033`	`+ }`
	`1034`	`+}`