Skip to content

Commit 033caf5

Browse files
committed
frontend: fix sidebar and app-content not scrollable css regression
With iOS prototype there was some updates to height / min-height for components that should spawn over the full height of the screen. This introduced a regression that the sidebar and app content are not scrollable. Introduced in e67a63c which was for sidebar only and followup of 02aba14. Other views or components that should be checked if scroll is working as intended are: - Bootloader view - Dialog - Guide Other components seem to not have the scrolling issue as those have either height or max-height set to 100vh and with that allow the user to scroll the content.
1 parent 3c38150 commit 033caf5

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

frontends/web/src/components/sidebar/sidebar.module.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
height: 100%;
3939
justify-content: flex-start;
4040
margin-left: calc(var(--sidebar-width-large) * -1);
41+
max-height: 100vh;
4142
/* mobile viewport bug fix */
4243
min-height: -webkit-fill-available;
4344
overflow-y: auto;

frontends/web/src/style/layout.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
height: 100vh;
7070
/* mobile viewport bug fix */
7171
height: -webkit-fill-available;
72+
max-height: 100vh;
7273
}
7374

7475
@media (max-width: 900px) {

0 commit comments

Comments
 (0)