Skip to content

Modbus Flex FC shows "broken" without map defined #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unclej84 opened this issue Dec 19, 2024 · 6 comments
Open

Modbus Flex FC shows "broken" without map defined #509

unclej84 opened this issue Dec 19, 2024 · 6 comments
Assignees
Labels

Comments

@unclej84
Copy link

Which node-red-contrib-modbus version are you using?

5.43.0

What happened?

When creating a new Flex FC node with only server and unitId defined but maps just filled with {} (empty) for use with maps defined on incoming messages, all mobdus nodes get status broken shortly after deploy. Maybe this is related to #508 as it tries to process empty request? This can only be fixed by having some map defined in the node even when not needed.

Server

Other/External server

How can this be reproduced?

create a new node, enter server and unitId without defining any map (default {}) and deploy

What did you expect to happen?

Default map without configuration should not break the modbus nodes / communication

Other Information

No response

@unclej84 unclej84 added the bug label Dec 19, 2024
@grewek grewek self-assigned this Dec 20, 2024
@grewek grewek moved this to Todo in P4NR Modbus v5 Dec 20, 2024
@grewek
Copy link

grewek commented Dec 20, 2024

Yes that seems like a bug, will put this on the list for things todo.
Thank you for the report!
This is also probably related to another bug i am currently working (our internal state-machine).
I will check this after Vacation.

Happy Holidays :)

@grewek
Copy link

grewek commented Jan 10, 2025

Hey, sorry for the waiting time hope you had great holidays :)

The bug that all clients go into a broken state is probably the same as #487. I am currently working on it but can't give you an exact estimate when the fix will be ready. There is however a workaround described in #487 maybe that helps
for now.

Thank you for your patience

@grewek grewek moved this from Todo to In Progress in P4NR Modbus v5 Jan 10, 2025
Copy link

This issue is stale because it has been open 60 days with no activity. It will be closed in 30 days, but can be saved by removing the stale label or commenting.

@github-actions github-actions bot added the Stale label Mar 12, 2025
@unclej84
Copy link
Author

just to remove stale label

@github-actions github-actions bot removed the Stale label Mar 13, 2025
Copy link

This issue is stale because it has been open 60 days with no activity. It will be closed in 30 days, but can be saved by removing the stale label or commenting.

@github-actions github-actions bot added the Stale label May 12, 2025
@unclej84
Copy link
Author

just to remove stale label

@github-actions github-actions bot removed the Stale label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants