Skip to content

Commit 0e85a57

Browse files
dilawarDilawar Singh
andauthored
Bugfix | moose.Streamer streams to numpy format correctly (#395)
* saving data to npy format in streamer is now bug free. Added three tests: 2 python and 1 at cpp level. * boost::filesystem is no longer used even when boost is used. * Default tick for Streamer is 10s. * Able to run nml2 example with python3 (BhallaLab/moose#253). Co-authored-by: Dilawar Singh <dilawars@ncbs.res.in>
1 parent 280dfa5 commit 0e85a57

File tree

19 files changed

+979
-763
lines changed

19 files changed

+979
-763
lines changed

basecode/Id.cpp

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,17 @@ string Id::id2str( Id id )
7676
string Id::path( const string& separator) const
7777
{
7878
string ret = Neutral::path( eref() );
79-
// Trim off trailing []
80-
assert( ret.length() > 0 );
81-
// the 'back' operation is not supported by pre 2011 compilers
8279

83-
while ( ret[ ret.length() - 1 ] == ']' )
80+
// FIXME: Monday 09 March 2020 12:30:27 PM IST, Dilawar Singh
81+
// This beaks the path comparison. Getting x.path from x returned in a
82+
// list by moose.wildcardFind() and getting path from here doesn't math
83+
// when this is enabled.
84+
// If we want to remove [0] then it should be done globally and not just
85+
// here.
86+
87+
// Trim off trailing []
88+
assert( ret.length() > 0 );
89+
while ( ret.back() == ']' )
8490
{
8591
size_t pos = ret.find_last_of( '[' );
8692
if ( pos != string::npos && pos > 0 )

0 commit comments

Comments
 (0)