From f94ee8bcbc17abacb86859648e0927131645ca5b Mon Sep 17 00:00:00 2001 From: Ishaan Jaff Date: Thu, 6 Mar 2025 07:54:40 -0800 Subject: [PATCH 1/2] add better debugging for async_read_secret --- litellm/secret_managers/aws_secret_manager_v2.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/litellm/secret_managers/aws_secret_manager_v2.py b/litellm/secret_managers/aws_secret_manager_v2.py index b72a709d86ea..3f3ae18ba4c1 100644 --- a/litellm/secret_managers/aws_secret_manager_v2.py +++ b/litellm/secret_managers/aws_secret_manager_v2.py @@ -93,7 +93,9 @@ async def async_read_secret( raise ValueError("Timeout error occurred") except Exception as e: verbose_logger.exception( - "Error reading secret from AWS Secrets Manager: %s", str(e) + "Error reading secret name=%s from AWS Secrets Manager: %s", + secret_name, + str(e), ) return None @@ -138,12 +140,15 @@ def sync_read_secret( raise ValueError("Timeout error occurred") except httpx.HTTPStatusError as e: verbose_logger.exception( - "Error reading secret from AWS Secrets Manager: %s", + "Error reading secret name=%s from AWS Secrets Manager: %s", + secret_name, str(e.response.text), ) except Exception as e: verbose_logger.exception( - "Error reading secret from AWS Secrets Manager: %s", str(e) + "Error reading secret name=%s from AWS Secrets Manager: %s", + secret_name, + str(e), ) return None From b94fbe10f2f9c9cd98ba07bba1e12d03d1fb8204 Mon Sep 17 00:00:00 2001 From: Ishaan Jaff Date: Thu, 6 Mar 2025 07:59:59 -0800 Subject: [PATCH 2/2] fix sync_read_secret --- .../secret_managers/aws_secret_manager_v2.py | 24 +++++-------------- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/litellm/secret_managers/aws_secret_manager_v2.py b/litellm/secret_managers/aws_secret_manager_v2.py index 3f3ae18ba4c1..5aabdc1c1c6f 100644 --- a/litellm/secret_managers/aws_secret_manager_v2.py +++ b/litellm/secret_managers/aws_secret_manager_v2.py @@ -90,14 +90,11 @@ async def async_read_secret( response.raise_for_status() return response.json()["SecretString"] except httpx.TimeoutException: - raise ValueError("Timeout error occurred") + raise ValueError(f"Timeout error occurred for secret name={secret_name}") except Exception as e: - verbose_logger.exception( - "Error reading secret name=%s from AWS Secrets Manager: %s", - secret_name, - str(e), + raise ValueError( + f"Error reading secret name={secret_name} from AWS Secrets Manager: {str(e)}" ) - return None def sync_read_secret( self, @@ -137,20 +134,11 @@ def sync_read_secret( ) return response.json()["SecretString"] except httpx.TimeoutException: - raise ValueError("Timeout error occurred") - except httpx.HTTPStatusError as e: - verbose_logger.exception( - "Error reading secret name=%s from AWS Secrets Manager: %s", - secret_name, - str(e.response.text), - ) + raise ValueError(f"Timeout error occurred for secret name={secret_name}") except Exception as e: - verbose_logger.exception( - "Error reading secret name=%s from AWS Secrets Manager: %s", - secret_name, - str(e), + raise ValueError( + f"Error reading secret name={secret_name} from AWS Secrets Manager: {str(e)}" ) - return None async def async_write_secret( self,