Skip to content

Commit 699b0ac

Browse files
committed
CI: Better factorization of extra_flags
1 parent 3ed81d0 commit 699b0ac

File tree

1 file changed

+15
-17
lines changed

1 file changed

+15
-17
lines changed

.github/workflows/build.yml

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
os: [macos-13, macos-14, macos-15, ubuntu-22.04, ubuntu-24.04]
1414
compiler: [ gfortran ]
1515
version: [ 12, 13, 14 ]
16-
extra_flags: [ -ffree-line-length-0 ]
16+
extra_flags: [ -g ]
1717

1818
exclude:
1919
- os: ubuntu-22.04
@@ -26,7 +26,6 @@ jobs:
2626
- os: ubuntu-24.04
2727
compiler: flang
2828
version: 20
29-
extra_flags: -g
3029
container: phhargrove/llvm-flang:20.1.0-1
3130
- os: ubuntu-24.04
3231
compiler: flang
@@ -37,27 +36,25 @@ jobs:
3736
# compiler: flang
3837
# version: new
3938
# container: gmao/llvm-flang:latest
40-
# extra_flags: -g
4139
- os: ubuntu-24.04
4240
compiler: ifx
4341
version: 2025.1.0
4442
error_stop_code: 128
45-
extra_flags: -g
4643
container: intel/fortran-essentials:2025.1.0-0-devel-ubuntu24.04
4744
#container: intel/oneapi-hpckit:2025.1.0-0-devel-ubuntu24.04
4845
- os: ubuntu-22.04
4946
compiler: ifx
5047
version: 2025.0.0
5148
error_stop_code: 128
52-
extra_flags: -g
5349
container: intel/fortran-essentials:2025.0.0-0-devel-ubuntu22.04
5450

5551
container:
5652
image: ${{ matrix.container }}
5753

5854
env:
59-
GCC_VERSION: ${{ matrix.version }}
55+
COMPILER_VERSION: ${{ matrix.version }}
6056
FC: ${{ matrix.compiler }}
57+
FFLAGS: ${{ matrix.extra_flags }}
6158
FPM_FLAGS: --profile release --verbose
6259

6360
steps:
@@ -69,9 +66,9 @@ jobs:
6966
run: |
7067
sudo apt-get update
7168
sudo apt list -a 'gfortran-*'
72-
sudo apt install -y gfortran-${GCC_VERSION} build-essential
73-
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-${GCC_VERSION} 100 \
74-
--slave /usr/bin/gfortran gfortran /usr/bin/gfortran-${GCC_VERSION}
69+
sudo apt install -y gfortran-${COMPILER_VERSION} build-essential
70+
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-${COMPILER_VERSION} 100 \
71+
--slave /usr/bin/gfortran gfortran /usr/bin/gfortran-${COMPILER_VERSION}
7572
7673
- name: Setup Compilers
7774
run: |
@@ -81,7 +78,8 @@ jobs:
8178
elif test "$FC" = "ifx" ; then \
8279
echo "FPM_FC=ifx" >> "$GITHUB_ENV" ; \
8380
else \
84-
echo "FPM_FC=gfortran-${GCC_VERSION}" >> "$GITHUB_ENV" ; \
81+
echo "FPM_FC=gfortran-${COMPILER_VERSION}" >> "$GITHUB_ENV" ; \
82+
echo "FFLAGS=-ffree-line-length-0 $FFLAGS" >> "$GITHUB_ENV" ; \
8583
fi
8684
if test -n "${{ matrix.error_stop_code }}" ; then \
8785
echo "ERROR_STOP_CODE=${{ matrix.error_stop_code }}" >> "$GITHUB_ENV" ; \
@@ -118,22 +116,22 @@ jobs:
118116
- name: Build and Test (Assertions OFF)
119117
run: |
120118
set -x
121-
fpm test ${FPM_FLAGS} --flag "${{ matrix.EXTRA_FLAGS }}"
122-
fpm run --example false-assertion ${FPM_FLAGS} --flag "${{ matrix.EXTRA_FLAGS }}"
123-
fpm run --example invoke-via-macro ${FPM_FLAGS} --flag "${{ matrix.EXTRA_FLAGS }}"
119+
fpm test ${FPM_FLAGS} --flag "$FFLAGS"
120+
fpm run --example false-assertion ${FPM_FLAGS} --flag "$FFLAGS"
121+
fpm run --example invoke-via-macro ${FPM_FLAGS} --flag "$FFLAGS"
124122
125123
- name: Build and Test (Assertions ON)
126124
env:
127125
FPM_FLAGS: ${{ env.FPM_FLAGS }} --flag -DASSERTIONS
128126
run: |
129127
set -x
130-
fpm test ${FPM_FLAGS} --flag "${{ matrix.EXTRA_FLAGS }}"
131-
( set +e ; fpm run --example false-assertion ${FPM_FLAGS} --flag "${{ matrix.EXTRA_FLAGS }}" ; test $? = $ERROR_STOP_CODE )
132-
( set +e ; fpm run --example invoke-via-macro ${FPM_FLAGS} --flag "${{ matrix.EXTRA_FLAGS }}" ; test $? = $ERROR_STOP_CODE )
128+
fpm test ${FPM_FLAGS} --flag "$FFLAGS"
129+
( set +e ; fpm run --example false-assertion ${FPM_FLAGS} --flag "$FFLAGS" ; test $? = $ERROR_STOP_CODE )
130+
( set +e ; fpm run --example invoke-via-macro ${FPM_FLAGS} --flag "$FFLAGS" ; test $? = $ERROR_STOP_CODE )
133131
134132
- name: Test Assertions w/ Parallel Callbacks
135133
env:
136134
FPM_FLAGS: ${{ env.FPM_FLAGS }} --flag -DASSERTIONS --flag -DASSERT_MULTI_IMAGE --flag -DASSERT_PARALLEL_CALLBACKS
137135
run: |
138136
set -x
139-
( set +e ; fpm run --example false-assertion ${FPM_FLAGS} --flag "${{ matrix.EXTRA_FLAGS }}" ; test $? = $ERROR_STOP_CODE )
137+
( set +e ; fpm run --example false-assertion ${FPM_FLAGS} --flag "$FFLAGS" ; test $? = $ERROR_STOP_CODE )

0 commit comments

Comments
 (0)