modified

Author: Benojir

app/src/main/java/zoro/benojir/callrecorder/helpers/RecorderHelper.java

@@ -3,6 +3,8 @@
 import android.content.Context;
 import android.content.SharedPreferences;
 import android.media.MediaRecorder;
+import android.os.Handler;
+import android.os.Looper;
 import android.util.Log;
 import android.widget.Toast;
 
@@ -55,33 +57,33 @@ public void startRecoding() {
             recorder.start();
 
             if (preferences.getBoolean("start_toast", false)) {
-                Toast.makeText(context, "Recording started", Toast.LENGTH_SHORT).show();
+                new Handler(Looper.getMainLooper()).post(() -> Toast.makeText(context, "Recording started!", Toast.LENGTH_SHORT).show());
             }
-
         } catch (Exception e) {
             Log.e(TAG, "startVoiceRecoding: ", e);
-            Toast.makeText(context, "Recording start failed! " + e.getMessage(), Toast.LENGTH_SHORT).show();
+            recorder = null;
+            new Handler(Looper.getMainLooper()).post(() -> Toast.makeText(context, "Recording start failed!", Toast.LENGTH_SHORT).show());
         }
     }
 //--------------------------------------------------------------------------------------------------
 
     public void stopVoiceRecoding() {
 
         try {
-            recorder.release();
             recorder.stop();
             recorder.reset();
+            recorder.release();
             recorder = null;
 
             if (preferences.getBoolean("saved_toast", false)) {
-                Toast.makeText(context, "Recording saved successfully!", Toast.LENGTH_SHORT).show();
+                new Handler(Looper.getMainLooper()).post(() -> Toast.makeText(context, "Recording saved successfully!", Toast.LENGTH_SHORT).show());
             }
         } catch (Exception e) {
             Log.e(TAG, "stopVoiceRecoding:", e);
             recorder = null;
 
             if (preferences.getBoolean("saved_toast", false)) {
-                Toast.makeText(context, "Recording saved!", Toast.LENGTH_SHORT).show();
+                new Handler(Looper.getMainLooper()).post(() -> Toast.makeText(context, "Recording saved!", Toast.LENGTH_SHORT).show());
             }
         }
     }

app/src/main/java/zoro/benojir/callrecorder/helpers/SharedPreferencesHelper.java

@@ -1,6 +1,6 @@
 <PreferenceScreen xmlns:app="http://schemas.android.com/apk/res-auto">
 
-    <PreferenceCategory app:title="@string/general_header">
+    <PreferenceCategory app:title="@string/recording_header">
 
         <SwitchPreferenceCompat
             app:key="is_call_recording_enabled"
@@ -22,9 +22,12 @@
             app:summaryOn="@string/saved_toast_summary_on"
             app:summaryOff="@string/saved_toast_summary_off"/>
 
+    </PreferenceCategory>
+
+    <PreferenceCategory app:title="@string/general_header">
+
         <ListPreference
             app:defaultValue="device_default"
-            app:dependency="is_call_recording_enabled"
             app:entries="@array/appearance_entries"
             app:entryValues="@array/appearance_values"
             app:key="appearance"
@@ -33,7 +36,6 @@
 
         <ListPreference
             app:defaultValue="sort_by_new"
-            app:dependency="is_call_recording_enabled"
             app:entries="@array/sort_by_entries"
             app:entryValues="@array/sort_by_values"
             app:key="sort_by"
@@ -42,19 +44,4 @@
 
     </PreferenceCategory>
 
-    <PreferenceCategory app:title="@string/recording_header">
-
-        <SwitchPreferenceCompat
-            app:key="sync"
-            app:title="@string/sync_title" />
-
-        <SwitchPreferenceCompat
-            app:dependency="sync"
-            app:key="attachment"
-            app:summaryOff="@string/attachment_summary_off"
-            app:summaryOn="@string/attachment_summary_on"
-            app:title="@string/attachment_title" />
-
-    </PreferenceCategory>
-
 </PreferenceScreen>