gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode

Marek Vasut · Bartosz Golaszewski · commit 8e88a0feebb2 · 2023-01-16T10:55:05.000+01:00
Always configure GPIO pins which are used as interrupt source as INPUTs. In case the default pin configuration is OUTPUT, or the prior stage does configure the pins as OUTPUT, then Linux will not reconfigure the pin as INPUT and no interrupts are received. Always configure the interrupt source GPIO pin as input to fix the above case. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Fixes: 07bd1a6 ("MXC arch: Add gpio support for the whole platform") Signed-off-by: Marek Vasut <marex@denx.de> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
@@ -223,7 +223,7 @@ static int gpio_set_irq_type(struct irq_data *d, u32 type)
 
 	raw_spin_unlock_irqrestore(&port->gc.bgpio_lock, flags);
 
-	return 0;
+	return port->gc.direction_input(&port->gc, gpio_idx);
 }
 
 static void mxc_flip_edge(struct mxc_gpio_port *port, u32 gpio)

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ static int gpio_set_irq_type(struct irq_data *d, u32 type)`
`223`	`223`
`224`	`224`	`raw_spin_unlock_irqrestore(&port->gc.bgpio_lock, flags);`
`225`	`225`
`226`		`- return 0;`
	`226`	`+ return port->gc.direction_input(&port->gc, gpio_idx);`
`227`	`227`	`}`
`228`	`228`
`229`	`229`	`static void mxc_flip_edge(struct mxc_gpio_port *port, u32 gpio)`