Skip to content

Commit 8ac1461

Browse files
committed
fix (aria-expanded) : add toggle text
1 parent 192446d commit 8ac1461

File tree

4 files changed

+16
-2
lines changed

4 files changed

+16
-2
lines changed

components/parts/common/header.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111

1212
<button class="header__menu-toggle" aria-expanded="false" aria-controls="menu">
1313
<span aria-hidden="true"></span>
14-
<span class="sr-only"><?php esc_html_e( 'Open/Close the menu', 'beapi-frontend-framework' ); ?></span>
14+
<span class="sr-only aria-expanded-false-text"><?php esc_html_e( 'Open the menu', 'beapi-frontend-framework' ); ?></span>
15+
<span class="sr-only aria-expanded-true-text"><?php esc_html_e( 'Close the menu', 'beapi-frontend-framework' ); ?></span>
1516
</button>
1617

1718
<nav id="menu" class="header__menu" aria-label="<?php esc_attr_e( 'Main navigation', 'beapi-frontend-framework' ); ?>" role="navigation">

inc/Helpers/Custom_Menu_Walker.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ public function start_el( &$output, $item, $depth = 0, $args = [], $id = 0 ) {
2424
$sub_menu_id = 'header-sub-menu-' . $item->ID;
2525

2626
$output .= '<button class="header__sub-menu-toggle" type="button" aria-expanded="false" aria-controls="' . esc_attr( $sub_menu_id ) . '">';
27-
$output .= esc_html__( 'Toggle menu', 'beapi-frontend-framework' );
27+
$output .= sprintf( '<span class="aria-expanded-false-text">%s</span>', esc_html__( 'Open menu', 'beapi-frontend-framework' ) );
28+
$output .= sprintf( '<span class="aria-expanded-true-text">%s</span>', esc_html__( 'Close menu', 'beapi-frontend-framework' ) );
2829
$output .= '</button>';
2930
$output .= sprintf( '<div id="%s" class="header__sub-menu %s"><div>', esc_attr( $sub_menu_id ), esc_attr( 'header__sub-menu-level-' . $depth ) );
3031
$output .= '<ul>';

src/scss/04-utilities/_aria.scss

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
[aria-expanded="false"] {
2+
.aria-expanded-true-text {
3+
display: none !important;
4+
}
5+
}
6+
7+
[aria-expanded="true"] {
8+
.aria-expanded-false-text {
9+
display: none !important;
10+
}
11+
}

src/scss/04-utilities/utilities.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,4 @@
66
@import "./container";
77
@import "./sr-only";
88
@import "./js-animation";
9+
@import "./aria";

0 commit comments

Comments
 (0)