Skip to content

Commit 4362d5d

Browse files
committed
fix: fix and refactors code for improved readability
Addresses minor code style issues identified by Sourcery. This commit focuses on improving code readability and consistency by destructuring objects and correcting a typo, without altering the core functionality. Also, clears a timeout in destroy function.
1 parent 86927d7 commit 4362d5d

File tree

5 files changed

+8
-11
lines changed

5 files changed

+8
-11
lines changed

src/js/classes/AbstractDomElement.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class AbstractDomElement {
3737
// provide an explicit spaceName to prevent conflict after minification
3838
// MaClass.nameSpace = 'MaClass'
3939
this.constructor.nameSpace = this.constructor.nameSpace || this.constructor.name
40-
const nameSpace = this.constructor.nameSpace
40+
const { nameSpace } = this.constructor
4141

4242
// if no spacename beapi, create it - avoid futur test
4343
if (!element.beapi) {
@@ -110,7 +110,7 @@ class AbstractDomElement {
110110
}
111111

112112
static initFromPreset() {
113-
const preset = this.preset
113+
const { preset } = this
114114
let selector
115115

116116
for (selector in preset) {
@@ -121,7 +121,7 @@ class AbstractDomElement {
121121
}
122122

123123
static destroyFromPreset() {
124-
const preset = this.preset
124+
const { preset } = this
125125
let selector
126126

127127
for (selector in preset) {

src/js/classes/Animation.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ class Animation extends AbstractDomElement {
151151
* Static are animations enabled
152152
* @returns {boolean}
153153
*/
154-
static areAnimationsEnbaled() {
154+
static areAnimationsEnabled() {
155155
return document.documentElement.classList.contains(animationClass)
156156
}
157157
}
@@ -262,7 +262,7 @@ Animation.preset = {
262262
})
263263

264264
const children = el.getElementsByClassName('st-line')
265-
const length = children.length
265+
const { length } = children
266266
let i
267267

268268
if (length > 1) {

src/js/classes/Header.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class Header extends AbstractDomElement {
8989
openSubMenu(liParent) {
9090
const toggle = liParent.children[1]
9191
const subMenu = liParent.children[2]
92-
var childHeight
92+
let childHeight
9393

9494
this._openedSubMenu = subMenu
9595

@@ -156,7 +156,7 @@ Header.defaults = {
156156
// events
157157
// ----
158158
function onKeyup(e) {
159-
const activeElement = document.activeElement
159+
const { activeElement } = document
160160

161161
// escape
162162
if (e.keyCode === 27) {

src/js/classes/ScrollDirection.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ class ScrollDirection extends AbstractDomElement {
7979
super.destroy()
8080
this._scrollObserver.unobserve(this._element)
8181
this._element.classList.remove('scroll-' + this._directions[this._current])
82+
clearTimeout(this._timer)
8283
}
8384
}
8485

src/scss/02-tools/_m-select-custom.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,4 @@
6565
outline: none;
6666
}
6767
}
68-
69-
@include rtl {
70-
background-position: left 10px top 50%, 0 0;
71-
}
7268
}

0 commit comments

Comments
 (0)