Merge pull request #394 from BeAPI/fix/svg-service-with-acf-svg-icon

ptesei · web-flow · commit 167d13440b17 · 2024-02-26T16:15:25.000+01:00
fix (theme): svg service compatibility with acf-svg-icon
diff --git a/inc/Services/Svg.php b/inc/Services/Svg.php
@@ -43,6 +43,10 @@ public function get_the_icon( string $icon_class, array $additionnal_classes = [
 			return '';
 		}
 
+		// acf-svg-icon already return sprite-name.svg#icon-name, ex: social.svg#icon-facebook
+		// format the string to obtain sprite-name/icon-name
+		$icon_class = str_replace( '.svg#icon-', '/', $icon_class );
+
 		$sprite_name = 'icons';
 
 		if ( false !== strpos( $icon_class, '/' ) ) {

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,10 @@ public function get_the_icon( string $icon_class, array $additionnal_classes = [`
`43`	`43`	`return '';`
`44`	`44`	`}`
`45`	`45`
	`46`	`+ // acf-svg-icon already return sprite-name.svg#icon-name, ex: social.svg#icon-facebook`
	`47`	`+ // format the string to obtain sprite-name/icon-name`
	`48`	`+ $icon_class = str_replace( '.svg#icon-', '/', $icon_class );`
	`49`	`+`
`46`	`50`	`$sprite_name = 'icons';`
`47`	`51`
`48`	`52`	`if ( false !== strpos( $icon_class, '/' ) ) {`