Skip to content

"Either" region hint being confusing #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Miepee opened this issue Jan 9, 2025 · 4 comments
Open

"Either" region hint being confusing #23

Miepee opened this issue Jan 9, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@Miepee
Copy link

Miepee commented Jan 9, 2025

"Either" what? Dark or light aether? Dark or light torvus?

@BashPrime
Copy link
Owner

It's meant to fill the use case for when your keys are hinted in two regions. Since it's unclear which of the two regions the third key will be in, I added in "either" to make it clear that you typed in the region while accounting for the two-region case.

@BashPrime BashPrime added the question Further information is requested label Jan 9, 2025
@Miepee
Copy link
Author

Miepee commented Jan 10, 2025

So if the dark keys were only in one region, you'd type:

Dark Agon
Either
Either

?

@BashPrime
Copy link
Owner

the way I envisioned it is that you'd just type one "Dark Agon" or set all three inputs to "Dark Agon". I think I can do better with the regions, but I want to keep the keys selectable so the player knows which keys they've collected

@BashPrime BashPrime added enhancement New feature or request and removed question Further information is requested labels Jan 10, 2025
@Miepee
Copy link
Author

Miepee commented Jan 10, 2025

I feel like itd be nicer to either:

  1. have the user just duplicate the region. E.g. Dark Agon, Dark Torvus, Dark Torvus
  2. have an "invalid/ N/A" field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants