Skip to content

Commit e54e940

Browse files
committed
Updates for Flutter beta channel
Run "dart fix --apply" on the beta channel
1 parent 651d43f commit e54e940

File tree

9 files changed

+22
-30
lines changed

9 files changed

+22
-30
lines changed

cached_network_image/example/lib/main.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import 'package:cached_network_image/cached_network_image.dart';
22
import 'package:flutter/material.dart';
3-
import 'package:flutter/widgets.dart';
43
import 'package:baseflow_plugin_template/baseflow_plugin_template.dart';
54
import 'package:flutter_blurhash/flutter_blurhash.dart';
65

cached_network_image/lib/src/cached_image_widget.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import 'package:cached_network_image/cached_network_image.dart';
22
import 'package:cached_network_image_platform_interface/cached_network_image_platform_interface.dart';
3-
import 'package:flutter/foundation.dart';
43
import 'package:flutter/material.dart';
54
import 'package:flutter/widgets.dart';
65
import 'package:flutter_cache_manager/flutter_cache_manager.dart';

cached_network_image/lib/src/image_provider/cached_network_image_provider.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ class CachedNetworkImageProvider
106106
headers,
107107
errorListener,
108108
imageRenderMethodForWeb,
109-
() => PaintingBinding.instance?.imageCache?.evict(key),
109+
() => PaintingBinding.instance.imageCache.evict(key),
110110
);
111111
}
112112

cached_network_image/lib/src/image_provider/multi_image_stream_completer.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ class MultiImageStreamCompleter extends ImageStreamCompleter {
149149
return;
150150
}
151151
_frameCallbackScheduled = true;
152-
SchedulerBinding.instance?.scheduleFrameCallback(_handleAppFrame);
152+
SchedulerBinding.instance.scheduleFrameCallback(_handleAppFrame);
153153
}
154154

155155
void _emitFrame(ImageInfo imageInfo) {

cached_network_image/pubspec.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: cached_network_image
22
description: Flutter library to load and cache network images.
33
Can also be used with placeholder and error widgets.
44
homepage: https://github.com/Baseflow/flutter_cached_network_image
5-
version: 3.2.0
5+
version: 3.2.1
66

77
dependencies:
88
flutter:
@@ -21,5 +21,4 @@ dev_dependencies:
2121
file: ^6.1.0
2222

2323
environment:
24-
flutter: ">=1.24.0-10.2.pre"
25-
sdk: ">=2.12.0 <3.0.0"
24+
sdk: ">=2.17.0-0 <3.0.0"

cached_network_image/test/image_cache_manager_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ void main() {
1515
setUp(() {});
1616

1717
tearDown(() {
18-
PaintingBinding.instance?.imageCache?.clear();
19-
PaintingBinding.instance?.imageCache?.clearLiveImages();
18+
PaintingBinding.instance.imageCache.clear();
19+
PaintingBinding.instance.imageCache.clearLiveImages();
2020
});
2121

2222
test('Supplying an ImageCacheManager should call getImageFile', () async {

cached_network_image/test/image_provider_test.dart

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import 'dart:math' as math;
77
import 'dart:ui' show Codec, FrameInfo;
88

99
import 'package:cached_network_image/cached_network_image.dart';
10-
import 'package:flutter/foundation.dart';
1110
import 'package:flutter/painting.dart';
1211
import 'package:flutter_cache_manager/flutter_cache_manager.dart';
1312
import 'package:flutter_test/flutter_test.dart';
@@ -26,8 +25,8 @@ void main() {
2625
});
2726

2827
tearDown(() {
29-
PaintingBinding.instance?.imageCache?.clear();
30-
PaintingBinding.instance?.imageCache?.clearLiveImages();
28+
PaintingBinding.instance.imageCache.clear();
29+
PaintingBinding.instance.imageCache.clearLiveImages();
3130
});
3231

3332
test('Expect thrown exception with statusCode - evicts from cache', () async {
@@ -39,13 +38,13 @@ void main() {
3938
final ImageProvider imageProvider = CachedNetworkImageProvider(
4039
nonconst(requestUrl),
4140
cacheManager: cacheManager);
42-
expect(imageCache?.pendingImageCount, 0);
43-
expect(imageCache?.statusForKey(imageProvider).untracked, true);
41+
expect(imageCache.pendingImageCount, 0);
42+
expect(imageCache.statusForKey(imageProvider).untracked, true);
4443

4544
final result = imageProvider.resolve(ImageConfiguration.empty);
4645

47-
expect(imageCache?.pendingImageCount, 1);
48-
expect(imageCache?.statusForKey(imageProvider).pending, true);
46+
expect(imageCache.pendingImageCount, 1);
47+
expect(imageCache.statusForKey(imageProvider).pending, true);
4948

5049
result.addListener(ImageStreamListener((ImageInfo info, bool syncCall) {},
5150
onError: (dynamic error, StackTrace? stackTrace) {
@@ -54,8 +53,8 @@ void main() {
5453

5554
final dynamic err = await caughtError.future;
5655

57-
expect(imageCache?.pendingImageCount, 0);
58-
expect(imageCache?.statusForKey(imageProvider).untracked, true);
56+
expect(imageCache.pendingImageCount, 0);
57+
expect(imageCache.statusForKey(imageProvider).untracked, true);
5958

6059
expect(
6160
err,

cached_network_image/test/image_stream_completer_test.dart

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -748,8 +748,7 @@ void main() {
748748
expect(lastListenerDropped, false);
749749
final handle = imageStream.keepAlive();
750750
expect(lastListenerDropped, false);
751-
SchedulerBinding.instance!
752-
.debugAssertNoTransientCallbacks('Only passive listeners');
751+
SchedulerBinding.instance.debugAssertNoTransientCallbacks('Only passive listeners');
753752

754753
codecStream.add(mockCodec);
755754
await tester.idle();
@@ -759,8 +758,7 @@ void main() {
759758
final frame1 = FakeFrameInfo(Duration.zero, image20x10);
760759
mockCodec.completeNextFrame(frame1);
761760
await tester.idle();
762-
SchedulerBinding.instance!
763-
.debugAssertNoTransientCallbacks('Only passive listeners');
761+
SchedulerBinding.instance.debugAssertNoTransientCallbacks('Only passive listeners');
764762
await tester.pump();
765763
expect(onImageCount, 0);
766764

@@ -769,7 +767,7 @@ void main() {
769767
final frame2 = FakeFrameInfo(Duration.zero, image10x10!);
770768
mockCodec.completeNextFrame(frame2);
771769
await tester.idle();
772-
expect(SchedulerBinding.instance!.transientCallbackCount, 1);
770+
expect(SchedulerBinding.instance.transientCallbackCount, 1);
773771
await tester.pump();
774772

775773
expect(onImageCount, 1);
@@ -779,18 +777,16 @@ void main() {
779777

780778
mockCodec.completeNextFrame(frame1);
781779
await tester.idle();
782-
expect(SchedulerBinding.instance!.transientCallbackCount, 1);
780+
expect(SchedulerBinding.instance.transientCallbackCount, 1);
783781
await tester.pump();
784782

785783
expect(onImageCount, 1);
786784

787-
SchedulerBinding.instance!
788-
.debugAssertNoTransientCallbacks('Only passive listeners');
785+
SchedulerBinding.instance.debugAssertNoTransientCallbacks('Only passive listeners');
789786

790787
mockCodec.completeNextFrame(frame2);
791788
await tester.idle();
792-
SchedulerBinding.instance!
793-
.debugAssertNoTransientCallbacks('Only passive listeners');
789+
SchedulerBinding.instance.debugAssertNoTransientCallbacks('Only passive listeners');
794790
await tester.pump();
795791

796792
expect(onImageCount, 1);

cached_network_image/test/image_widget_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ void main() {
1313
});
1414

1515
tearDown(() {
16-
PaintingBinding.instance?.imageCache?.clear();
17-
PaintingBinding.instance?.imageCache?.clearLiveImages();
16+
PaintingBinding.instance.imageCache.clear();
17+
PaintingBinding.instance.imageCache.clearLiveImages();
1818
});
1919

2020
group('test logger', () {

0 commit comments

Comments
 (0)