Skip to content

Commit 588fc77

Browse files
committed
Update after review
1 parent 568e3cb commit 588fc77

22 files changed

+434
-312
lines changed

cached_network_image/CHANGELOG.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
1-
## [3.2.4] - TBD
2-
* Support Dart 3.0.0 for http ^1.0.0 and file ^7.0.0
1+
## [3.3.0] - TBD
2+
* Add error to ErrorListener
3+
* Update to Dart 3
34
* Add topics
45
* Specify types
5-
* Add error to ErrorListener
66
* Update example
7-
* Use `loadImage` instead `loadBuffer`
8-
* Remove [`load`](https://github.com/flutter/flutter/pull/132679)
7+
* Remove [`load`](https://github.com/flutter/flutter/pull/132679), use `loadImage` instead `loadBuffer`
98

109
## [3.2.3] - 2022-11-25
1110
* Correctly dispose image stream handler
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
include: package:flutter_lints/flutter.yaml
1+
include: package:flutter_lints/flutter.yaml

cached_network_image/example/lib/main.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ class BasicContent extends StatelessWidget {
115115
placeholder: (context, url) =>
116116
const CircularProgressIndicator(),
117117
errorWidget: (context, url, error) => const Icon(Icons.error),
118-
fadeOutDuration: const Duration(seconds: 1),
119118
fadeInDuration: const Duration(seconds: 3),
120119
),
121120
),

cached_network_image/example/macos/Runner/DebugProfile.entitlements

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,7 @@
88
<true/>
99
<key>com.apple.security.network.server</key>
1010
<true/>
11+
<key>com.apple.security.network.client</key>
12+
<true/>
1113
</dict>
1214
</plist>

cached_network_image/example/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ dependencies:
1717
dev_dependencies:
1818
flutter_test:
1919
sdk: flutter
20-
flutter_lints: ^2.0.2
20+
flutter_lints: ^2.0.3
2121

2222
flutter:
2323
uses-material-design: true
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
dependency_overrides:
2+
cached_network_image_platform_interface:
3+
path:
4+
../../cached_network_image_platform_interface
5+
cached_network_image_web:
6+
path:
7+
../../cached_network_image_web

cached_network_image/lib/src/cached_image_widget.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ class CachedNetworkImage extends StatelessWidget {
5555
BaseCacheManager? cacheManager,
5656
double scale = 1,
5757
}) async {
58-
final newCacheManager = cacheManager ?? DefaultCacheManager();
59-
await newCacheManager.removeFile(cacheKey ?? url);
58+
final effectiveCacheManager = cacheManager ?? DefaultCacheManager();
59+
await effectiveCacheManager.removeFile(cacheKey ?? url);
6060
return CachedNetworkImageProvider(url, scale: scale).evict();
6161
}
6262

cached_network_image/lib/src/image_provider/_image_loader.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ class ImageLoader implements platform.ImageLoader {
2323
int? maxHeight,
2424
int? maxWidth,
2525
Map<String, String>? headers,
26-
ValueChanged<Object>? errorListener,
2726
ImageRenderMethodForWeb imageRenderMethodForWeb,
2827
VoidCallback evictImage,
2928
) {
@@ -39,7 +38,7 @@ class ImageLoader implements platform.ImageLoader {
3938
maxHeight,
4039
maxWidth,
4140
headers,
42-
errorListener,
41+
(_) {},
4342
imageRenderMethodForWeb,
4443
evictImage,
4544
);

cached_network_image/lib/src/image_provider/cached_network_image_provider.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ class CachedNetworkImageProvider
104104
maxHeight,
105105
maxWidth,
106106
headers,
107-
errorListener,
108107
imageRenderMethodForWeb,
109108
() => PaintingBinding.instance.imageCache.evict(key),
110109
);

cached_network_image/pubspec.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,22 @@ topics:
66
- cache
77
- image
88
- network-image
9-
version: 3.2.4
9+
version: 3.3.0
1010
environment:
1111
sdk: ^3.0.0
1212
flutter: '>=3.10.0'
1313

1414
dependencies:
15-
cached_network_image_platform_interface: ^2.0.1
16-
cached_network_image_web: ^1.0.3
15+
cached_network_image_platform_interface: ^3.0.0
16+
cached_network_image_web: ^1.1.0
1717
flutter:
1818
sdk: flutter
1919
flutter_cache_manager: ^3.3.1
2020
octo_image: ^1.0.2
2121

2222
dev_dependencies:
2323
file: '>=6.1.4 <8.0.0'
24-
flutter_lints: ^2.0.2
24+
flutter_lints: ^2.0.3
2525
flutter_test:
2626
sdk: flutter
2727
mocktail: ^1.0.0

0 commit comments

Comments
 (0)