evict and add only on 404

ltOgt · martijn00 · commit 942bc8db3c25 · 2024-07-31T22:20:21.000+02:00
diff --git a/flutter_cache_manager/lib/src/cache_manager.dart b/flutter_cache_manager/lib/src/cache_manager.dart
@@ -151,10 +151,12 @@ class CacheManager implements BaseCacheManager {
         cacheLogger.log(
             'CacheManager: Failed to download file from $url with error:\n$e',
             CacheManagerLogLevel.debug);
-        if (streamController.hasListener) {
+        if (cacheFile == null && streamController.hasListener) {
           streamController.addError(e);
         }
-        if (cacheFile != null) {
+
+        if (cacheFile != null && e is HttpExceptionWithStatus && e.statusCode == 404) {
+          streamController.addError(e);
           await removeFile(key);
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -151,10 +151,12 @@ class CacheManager implements BaseCacheManager {`
`151`	`151`	`cacheLogger.log(`
`152`	`152`	`'CacheManager: Failed to download file from $url with error:\n$e',`
`153`	`153`	`CacheManagerLogLevel.debug);`
`154`		`- if (streamController.hasListener) {`
	`154`	`+ if (cacheFile == null && streamController.hasListener) {`
`155`	`155`	`streamController.addError(e);`
`156`	`156`	`}`
`157`		`- if (cacheFile != null) {`
	`157`	`+`
	`158`	`+ if (cacheFile != null && e is HttpExceptionWithStatus && e.statusCode == 404) {`
	`159`	`+ streamController.addError(e);`
`158`	`160`	`await removeFile(key);`
`159`	`161`	`}`
`160`	`162`	`}`