BN-47 | Add. Patient Allergies Display Control #7
Conversation
| const { allergies, loading, error } = useAllergies(patientUUID); | ||
|
|
||
| // Define table headers | ||
| const headers = useMemo( |
There was a problem hiding this comment.
What is the need for useMemo here ? this is a simple constant with no calculation involved
There was a problem hiding this comment.
If you defined the headers array directly in the render function (i.e., without useMemo), a new array reference would be created on every render. Even though the contents are the same, React (or child components) may interpret the new reference as a change — especially if the child component (like ExpandableDataTable) is using React.memo() or does deep equality checks to avoid re-renders.
src/__mocks__/allergyMocks.ts
Outdated
| import { | ||
| FhirAllergyIntolerance, | ||
| FhirAllergyIntoleranceBundle, | ||
| } from '../types/allergy'; |
There was a problem hiding this comment.
Here we should, missed it.
| import React, { useMemo } from 'react'; | ||
| import { Tag } from '@carbon/react'; | ||
| import { ExpandableDataTable } from '../../components/expandableDataTable/ExpandableDataTable'; | ||
| import { usePatientUUID } from '../../hooks/usePatientUUID'; |
There was a problem hiding this comment.
Shouldn't all the following imports use alias ?
| @@ -0,0 +1,283 @@ | |||
| import React from 'react'; | |||
| import { renderHook, act, waitFor } from '@testing-library/react'; | |||
| import { useAllergies } from '../useAllergies'; | |||
There was a problem hiding this comment.
Since this a test for useAllergies available in the same sub folder, using an alias is an overkill.
| * @param delimiters - Optional string of delimiter characters (default: " -", space and hyphen) | ||
| * @returns The string in capital case | ||
| */ | ||
| export function capitalize(input: string, delimiters: string = ' -'): string { |
There was a problem hiding this comment.
Captialize is confusing. The result of this function is sentenceCase not capitalCase. Can we think of a better method naming ?
There was a problem hiding this comment.
The result of the function would be "Foo Bar" for an input of "foo bar". Sentence case is when only the first character is in uppercase and the rest is all in lower (eg- "Foo bar").
JIRA -> BN-47
This PR adds functionality to display a patient's allergies on the dashboard, ensuring all allergies are clearly presented with relevant details.
Key Features
Implementation Details
Next Steps