BN-44 | Fix. Show Business Errors When Axios Fails

Author: rahu1ramesh

src/utils/__tests__/common.test.ts

@@ -3,6 +3,7 @@ import axios, { AxiosError } from 'axios';
 
 jest.mock('axios', () => ({
   isAxiosError: jest.fn(),
+  get: jest.fn(),
 }));
 
 const mockedAxios = axios as jest.Mocked<typeof axios>;
@@ -345,34 +346,7 @@ describe('common utility functions', () => {
 
     it('should handle generic Error objects', () => {
       const error = new Error('Something went wrong');
-      error.name = 'ValidationError';
-
-      mockedAxios.isAxiosError.mockReturnValue(false);
-
-      const result = getFormattedError(error);
-
-      expect(result).toEqual({
-        title: 'ValidationError',
-        message: 'Something went wrong',
-      });
-    });
-
-    it('should return error object input', () => {
-      const result = getFormattedError({
-        message: 'An unknown error',
-      });
-      expect(result).toEqual({
-        title: 'Error',
-        message: 'An unknown error occurred',
-      });
-    });
-
-    it('should handle generic Error objects without name', () => {
-      const error = new Error('Something went wrong');
-      error.name = undefined; // Set name to undefined for this test
-
-      mockedAxios.isAxiosError.mockReturnValue(false);
-
+      mockedAxios.get.mockRejectedValue(error);
       const result = getFormattedError(error);
 
       expect(result).toEqual({

src/utils/common.ts

@@ -19,15 +19,11 @@ export const getFormattedError = (
 
   if (typeof error === 'string') {
     message = error;
-  } else if (error instanceof Error) {
-    title = error.name || 'Error';
-    message = error.message;
   } else if (axios.isAxiosError(error)) {
     const axiosError = error as AxiosError;
 
     if (axiosError?.response) {
       const status = axiosError.response.status;
-
       switch (status) {
         case 400:
           title = 'Bad Request';
@@ -60,11 +56,15 @@ export const getFormattedError = (
             'Error processing your request';
         }
       }
+    } else if (error instanceof Error) {
+      message = error.message;
     } else {
       title = 'Network Error';
       message =
         'Unable to connect to the server. Please check your internet connection.';
     }
+  } else if (error instanceof Error) {
+    message = error.message;
   } else {
     message = 'An unknown error occurred';
   }