update translate method return

Author: arkadiusjonczek

src/DeepL.php

@@ -121,7 +121,7 @@ public function __destruct()
      * @param $sourceLanguage      string
      * @param $destinationLanguage string
      *
-     * @return array
+     * @return string|string[]
      *
      * @throws DeepLException
      */
@@ -130,9 +130,22 @@ public function translate($text, $sourceLanguage = 'de', $destinationLanguage =
         // make sure we only accept supported languages
         $this->checkLanguages($sourceLanguage, $destinationLanguage);
 
+        // build the DeepL API request url
         $url = $this->buildUrl($text, $sourceLanguage, $destinationLanguage);
 
-        return $this->request($url);
+        // request the DeepL API
+        $translationsArray = $this->request($url);
+        $translationsCount = count($translationsArray['translations']);
+
+        if ($translationsCount == 0) {
+            throw new DeepLException('No translations found.');
+        }
+        else if ($translationsCount == 1) {
+            return $translationsArray['translations'][0]['text'];
+        }
+        else {
+            return $translationsArray['translations'];
+        }
     }
 
     /**
@@ -216,6 +229,10 @@ protected function request($url)
 
         $translationsArray = json_decode($response, true);
 
+        if (!$translationsArray) {
+            throw new DeepLException('The Response seems to not be valid JSON.');
+        }
+
         return $translationsArray;
     }
 }

tests/DeepLTest.php

@@ -102,9 +102,9 @@ public function testTranslate()
 
         $deepl     = new DeepL($authKey);
 
-        $response = $deepl->translate($germanText);
+        $translatedText = $deepl->translate($germanText);
 
-        $this->assertEquals('Hello World', $response['translations'][0]['text']);
+        $this->assertEquals('Hello World', $translatedText);
     }
 
     /**
@@ -121,6 +121,6 @@ public function testTranslateException()
 
         $this->setExpectedException('\BabyMarkt\DeepL\DeepLException');
 
-        $response = $deepl->translate($germanText);
+        $translatedText = $deepl->translate($germanText);
     }
 }