- remove checkLanguages with Tests

Author: VimS

src/DeepL.php

@@ -31,46 +31,6 @@ class DeepL
      */
     const API_URL_RESOURCE_LANGUAGES = 'languages';
 
-    /**
-     * Supported translation source languages
-     *
-     * @var array
-     */
-    protected $sourceLanguages = array(
-        'EN',
-        'DE',
-        'FR',
-        'ES',
-        'PT',
-        'IT',
-        'NL',
-        'PL',
-        'RU',
-        'JA',
-        'ZH',
-    );
-
-    /**
-     * Supported translation destination languages
-     *
-     * @var array
-     */
-    protected $destinationLanguages = array(
-        'EN',
-        'DE',
-        'FR',
-        'ES',
-        'PT',
-        'PT-PT',
-        'PT-BR',
-        'IT',
-        'NL',
-        'PL',
-        'RU',
-        'JA',
-        'ZH',
-    );
-
     /**
      * DeepL API Version (v2 is default since 2018)
      *
@@ -265,9 +225,6 @@ public function translate(
         );
         $paramsArray = $this->removeEmptyParams($paramsArray);
 
-        // make sure we only accept supported languages
-        $this->checkLanguages($sourceLanguage, $destinationLanguage);
-
         $url  = $this->buildBaseUrl();
         $body = $this->buildQuery($paramsArray);
 
@@ -306,37 +263,6 @@ private function removeEmptyParams($paramsArray)
         return $paramsArray;
     }
 
-    /**
-     * Check if the given languages are supported
-     *
-     * @param string $sourceLanguage
-     * @param string $destinationLanguage
-     *
-     * @return boolean
-     *
-     * @throws DeepLException
-     */
-    protected function checkLanguages($sourceLanguage, $destinationLanguage)
-    {
-        $sourceLanguage = strtoupper($sourceLanguage);
-
-        if (false === in_array($sourceLanguage, $this->sourceLanguages)) {
-            throw new DeepLException(
-                sprintf('The language "%s" is not supported as source language.', $sourceLanguage)
-            );
-        }
-
-        $destinationLanguage = strtoupper($destinationLanguage);
-
-        if (false === in_array($destinationLanguage, $this->destinationLanguages)) {
-            throw new DeepLException(
-                sprintf('The language "%s" is not supported as destination language.', $destinationLanguage)
-            );
-        }
-
-        return true;
-    }
-
     /**
      * @param array $paramsArray
      *

tests/unit/DeepLTest.php

@@ -14,21 +14,6 @@
  */
 class DeepLTest extends PHPUnit_Framework_TestCase
 {
-    /**
-     * Test checkLanguages()
-     */
-    public function testCheckLanguages()
-    {
-        $authKey = '123456';
-        $deepl   = new DeepL($authKey);
-
-        $checkLanguages = self::getMethod('\BabyMarkt\DeepL\DeepL', 'checkLanguages');
-
-        $return = $checkLanguages->invokeArgs($deepl, array('de', 'en'));
-
-        $this->assertTrue($return);
-    }
-
     /**
      * Get protected method
      *
@@ -48,36 +33,6 @@ protected static function getMethod($className, $methodName)
         return $method;
     }
 
-    /**
-     * Test checkLanguages() with exception for source language
-     */
-    public function testCheckLanguagesSourceLanguageException()
-    {
-        $authKey = '123456';
-        $deepl   = new DeepL($authKey);
-
-        $checkLanguages = self::getMethod('\BabyMarkt\DeepL\DeepL', 'checkLanguages');
-
-        $this->setExpectedException('\BabyMarkt\DeepL\DeepLException');
-
-        $checkLanguages->invokeArgs($deepl, array('fo', 'en'));
-    }
-
-    /**
-     * Test checkLanguages() with exception for destination language
-     */
-    public function testCheckLanguagesDestinationLanguageException()
-    {
-        $authKey = '123456';
-        $deepl   = new DeepL($authKey);
-
-        $checkLanguages = self::getMethod('\BabyMarkt\DeepL\DeepL', 'checkLanguages');
-
-        $this->setExpectedException('\BabyMarkt\DeepL\DeepLException');
-
-        $checkLanguages->invokeArgs($deepl, array('de', 'fo'));
-    }
-
     /**
      * Test translate()
      */