send text as POST body to solve 414 uri too long error

Author: arkadiusjonczek

src/DeepL.php

@@ -131,10 +131,11 @@ public function translate($text, $sourceLanguage = 'de', $destinationLanguage =
         $this->checkLanguages($sourceLanguage, $destinationLanguage);
 
         // build the DeepL API request url
-        $url = $this->buildUrl($text, $sourceLanguage, $destinationLanguage);
+        $url  = $this->buildUrl($sourceLanguage, $destinationLanguage);
+        $body = $this->buildBody($text);
 
         // request the DeepL API
-        $translationsArray = $this->request($url);
+        $translationsArray = $this->request($url, $body);
         $translationsCount = count($translationsArray['translations']);
 
         if ($translationsCount == 0) {
@@ -184,22 +185,42 @@ protected function checkLanguages($sourceLanguage, $destinationLanguage)
      *
      * @return string
      */
-    protected function buildUrl($text, $sourceLanguage, $destinationLanguage)
+    protected function buildUrl($sourceLanguage, $destinationLanguage)
     {
+        $url = DeepL::API_URL . '?' . sprintf(DeepL::API_URL_AUTH_KEY, $this->authKey);
+
+        $url .= '&' . sprintf(DeepL::API_URL_SOURCE_LANG, strtolower($sourceLanguage));
+        $url .= '&' . sprintf(DeepL::API_URL_DESTINATION_LANG, strtolower($destinationLanguage));
+
+        return $url;
+    }
+
+    /**
+     * Build the body for the DeepL API request
+     *
+     * @param $text
+     *
+     * @return string
+     */
+    protected function buildBody($text)
+    {
+        $body  = '';
+        $first = true;
+
         if (!is_array($text)) {
             $text = (array)$text;
         }
 
-        $url = DeepL::API_URL . '?' . sprintf(DeepL::API_URL_AUTH_KEY, $this->authKey);
-
         foreach ($text as $textElement) {
-            $url .= '&' . sprintf(DeepL::API_URL_TEXT, rawurlencode($textElement));
-        }
 
-        $url .= '&' . sprintf(DeepL::API_URL_SOURCE_LANG, strtolower($sourceLanguage));
-        $url .= '&' . sprintf(DeepL::API_URL_DESTINATION_LANG, strtolower($destinationLanguage));
+            $body .= ($first ? '' : '&') . sprintf(DeepL::API_URL_TEXT, rawurlencode($textElement));
 
-        return $url;
+            if ($first) {
+                $first = false;
+            }
+        }
+
+        return $body;
     }
 
     /**
@@ -211,9 +232,12 @@ protected function buildUrl($text, $sourceLanguage, $destinationLanguage)
      *
      * @throws DeepLException
      */
-    protected function request($url)
+    protected function request($url, $body)
     {
         curl_setopt($this->curl, CURLOPT_URL, $url);
+        curl_setopt($this->curl, CURLOPT_POSTFIELDS, $body);
+        curl_setopt($this->curl, CURLOPT_HTTPHEADER, array('Content-Type: application/x-www-form-urlencoded'));
+
         $response = curl_exec($this->curl);
 
         if (!curl_errno($this->curl)) {

tests/DeepLTest.php

@@ -76,24 +76,51 @@ public function testCheckLanguagesDestinationLanguageException()
      */
     public function testBuildUrl()
     {
-        $expectedString = 'https://api.deepl.com/v1/translate?auth_key=123456&text=Hallo%20Welt&source_lang=de&target_lang=en';
+        $expectedString = 'https://api.deepl.com/v1/translate?auth_key=123456&source_lang=de&target_lang=en';
 
         $authKey = '123456';
         $deepl   = new DeepL($authKey);
 
         $buildUrl = self::getMethod('\BabyMarkt\DeepL\DeepL', 'buildUrl');
 
-        $return = $buildUrl->invokeArgs($deepl, array('Hallo Welt', 'de', 'en'));
+        $return = $buildUrl->invokeArgs($deepl, array('de', 'en'));
 
         $this->assertEquals($expectedString, $return);
     }
 
     /**
-     * Test translate()
+     * Test buildBody()
+     */
+    public function testBuildBody()
+    {
+        $expectedString = 'text=Hallo%20Welt';
+
+        $authKey = '123456';
+        $deepl   = new DeepL($authKey);
+
+        $buildUrl = self::getMethod('\BabyMarkt\DeepL\DeepL', 'buildBody');
+
+        $return = $buildUrl->invokeArgs($deepl, array('Hallo Welt'));
+
+        $this->assertEquals($expectedString, $return);
+    }
+
+    /**
+     * Test translate() calls
+     */
+    public function testTranslate()
+    {
+        $mock = $this->getMockBuilder('\BabyMarkt\DeepL\DeepL');
+
+        // TODO: test if translate methods calls correct methods
+    }
+
+    /**
+     * Test translate() success
      *
      * TEST REQUIRES VALID DEEPL AUTH KEY!!
      */
-    public function testTranslate()
+    public function testTranslateSuccess()
     {
         return;