Close #705 Negative axis 0 index in distribution plot error

Author: albavilanova

providentia/plot_aux.py

@@ -337,7 +337,8 @@ def kde_fft(xin, gridsize=1024, extents=None, weights=None, adjust=1., bw='scott
     else:
         weights = np.squeeze(np.asarray(weights))
         if weights.size != x.size:
-            raise ValueError('Input weights must be an array of the same size as xin!')
+            error = 'Input weights must be an array of the same size as xin. '
+            return error
 
     # Optimize gridsize ------------------------------------------------------
     # Make grid and discretize the data and round it to the next power of 2
@@ -363,7 +364,11 @@ def kde_fft(xin, gridsize=1024, extents=None, weights=None, adjust=1., bw='scott
     # Next, make a histogram of x
     # Exploit a sparse coo_matrix avoiding np.histogram due to excessive
     # memory usage with many points
-    grid = coo_matrix((weights, xyi), shape=(nx, 1)).toarray()
+    try:
+        grid = coo_matrix((weights, xyi), shape=(nx, 1)).toarray()
+    except ValueError:
+        error = 'Too many zeros. '
+        return error
 
     # Kernel Preliminary Calculations ---------------------------------------
     std_x = np.std(xyi[0])
@@ -380,7 +385,10 @@ def kde_fft(xin, gridsize=1024, extents=None, weights=None, adjust=1., bw='scott
 
     # If bandwidth is 0, skip plot for current data label
     if kern_nx == 0:
-        return None
+        error = 'The kernel bandwidth is 0.  '
+        error += 'To change the bandwith, we recommend increasing the number of '
+        error += 'pdf_min_samples in the plot characteristics settings files. '
+        return error
 
     # Then evaluate the gaussian function on the kernel grid
     kernel = np.reshape(gaussian(kern_nx, bw_factor * std_x), (kern_nx, 1))

providentia/plotting.py

@@ -1148,11 +1148,9 @@ def make_distribution(self, relevant_axis, networkspeci, data_labels, plot_chara
                         #PDF_fit = FFTKDE(kernel='gaussian', bw='scott').fit(kde_data_obs)
                         #PDF_obs_sampled = PDF_fit.evaluate(x_grid)
 
-                        if PDF_obs_sampled is None:
-                            msg = 'The kernel bandwidth is 0 for {}. '.format(data_label)
-                            msg += 'The distribution plot will be created and not include data for this label. '
-                            msg += 'To change the bandwith, we recommend increasing the number of '
-                            msg += 'pdf_min_samples in the plot characteristics settings files.'
+                        if isinstance(PDF_obs_sampled, str):
+                            msg = PDF_obs_sampled
+                            msg += f'The distribution plot will be created and not include data for this label ({data_label}). '
                             show_message(self.read_instance, msg)
                             continue
 
@@ -1173,11 +1171,9 @@ def make_distribution(self, relevant_axis, networkspeci, data_labels, plot_chara
                     continue
                 # calculate PDF
                 PDF_model_sampled = kde_fft(kde_data_model, xgrid=x_grid)
-                if PDF_model_sampled is None:
-                    msg = 'The kernel bandwidth is 0 for {}. '.format(data_label)
-                    msg += 'The distribution plot will be created and not include data for this label. '
-                    msg += 'To change the bandwith, we recommend increasing the number of '
-                    msg += 'pdf_min_samples in the plot characteristics settings files.'
+                if isinstance(PDF_model_sampled, str):
+                    msg = PDF_model_sampled
+                    msg += f'The distribution plot will be created and not include data for this label ({data_label}). '
                     show_message(self.read_instance, msg)
                     continue
 
@@ -1243,11 +1239,9 @@ def make_distribution(self, relevant_axis, networkspeci, data_labels, plot_chara
                         continue
                     else:
                         PDF_sampled = kde_fft(kde_data, xgrid=x_grid)
-                        if PDF_sampled is None:
-                            msg = 'The kernel bandwidth is 0 for {}. '.format(data_label)
-                            msg += 'The distribution plot will be created and not include data for this label. '
-                            msg += 'To change the bandwith, we recommend increasing the number of '
-                            msg += 'pdf_min_samples in the plot characteristics settings files.'
+                        if isinstance(PDF_sampled, str):
+                            msg = PDF_sampled
+                            msg += f'The distribution plot will be created and not include data for this label ({data_label}). '
                             show_message(self.read_instance, msg)
                             continue