STYLE: Remove unused type aliases to improve code readability

Author: hjmjohnson

BRAINSConstellationDetector/src/BinaryMaskEditorBasedOnLandmarks.cxx

@@ -290,7 +290,6 @@ main(int argc, char * argv[])
   ImageType::Pointer outputVolume = duplicator->GetOutput();
 
   // cut by landmarks
-  using stringVectorIteratorType = std::vector<std::string>::const_iterator;
   for (auto ldmkIt = inputLandmarkNames.begin(), dircIt = setCutDirectionForLandmark.begin();
        ldmkIt < inputLandmarkNames.end();
        ++ldmkIt, ++dircIt)
@@ -312,7 +311,6 @@ main(int argc, char * argv[])
 
   // string vector to read in a vector of three elements.
   // ex) (LE, RE, PC) --> plane for left and right eyes with posterior commissure.
-  using LandMarkForPlaneType = std::vector<std::string>;
 
   // a set of plane description
   // ex) 1: (LE, RE, PC)

BRAINSConstellationDetector/src/landmarksConstellationDetector.cxx

@@ -120,9 +120,8 @@ landmarksConstellationDetector::ComputeFinalRefinedACPCAlignedTransform(
     using LandmarkBasedInitializerType =
       itk::LandmarkBasedTransformInitializer<LmkInitTransformType, SImageType, SImageType>;
     using LandmarkContainerType = LandmarkBasedInitializerType::LandmarkPointContainer;
-    LandmarkContainerType atlasLmks;
-    LandmarkContainerType movingLmks;
-    using LandmarkConstIterator = LandmarksMapType::const_iterator;
+    LandmarkContainerType                            atlasLmks;
+    LandmarkContainerType                            movingLmks;
     LandmarkBasedInitializerType::LandmarkWeightType landmarkWgts;
     for (auto fixedIt = referenceAtlasLandmarks.begin(); fixedIt != referenceAtlasLandmarks.end(); ++fixedIt)
     {

BRAINSLandmarkInitializer/BRAINSLandmarkInitializer.cxx

@@ -132,7 +132,6 @@ PreProcessLandmarkFiles(const std::string &      inputFixedLandmarkFilename,
     CheckLandmarks(movingLandmarks, landmarkWeightMap);
   }
 
-  using LandmarkConstIterator = LandmarksMapType::const_iterator;
   for (auto & fixedLandmark : fixedLandmarks)
   {
     auto movingIt = movingLandmarks.find(fixedLandmark.first);