New IDS check

As IDS was released as a first version with 1.0 last year, it would be better to move these checks into a IDS and have a format that is accepted for IFC in the community.

User Manual for IDS
Developer Guide

First implementation

General

• Each GUID should be unique

BPS

• Existence of IfcRelSpaceBoundary2ndLevel or at least IfcRelSpaceBoundary with description=2ndLevel for every IfcSpace that is not ExternalSpatial
• Each IfcRelSpaceBoundary should have a:
  • RelatingSpace
  • RelatedBuildingElement
• Each IfcProduct should have a Representation

HVAC

• each component of HVACProduct should have ports
• each port should have flow direction
• ...

Relevant software

• Software Implementations

OLD:

General

• We implemented already the following tasks:
  • CheckIfc: a base task that runs all checks that are needed for every workflow and plugin
  • CheckIfcHVAC: performs all tasks from CheckIFC and some HVAC specific stuff
  • CheckIfcBPS: performs all tasks from CheckIFC and some BPS specific stuff

Following, we can discuss and add things to the list we want to check

CheckIfc: General stuff to check

• IFC version must be IFC4

CheckIfcBPS

• This can be based on the Checker class of the bps.py
• Check if SBs are available, raise error otherwise
• Check for duplicate GlobalIDs: Two stage check:
  • Warning for guids that are duplicated when evaluating upper-case: Results in Errors for EnergyPlus
  • Error for duplicate GlobalIDs
  • Recommend using the "reset guid"-Flag in config

CheckIfcHVAC

• no ports -> abort

maybe for validation of each element and not prior validation check

• check for each element the number of ports:
  • e.g. pipe: 2, boiler: 4 ...

Most of the checks here are already implemented and already output to HTML error reports, but failed checks don't lead to errors and program abort. For some fatal stuff we should implement that the program stops. This is strongly related to #445 :

• IFC Version must be IFC 4
• no ports in HVAC
• no SBs in BPS
• doubled GUIDs (advice to turn on setting to reset guids)

related (old) issues:

• refactor CheckIfcBPS #226