@markAsLro doesn't behave correctly

[pshao25]

Case 1: response 200 with body and 202 without body

Real case in cost-management.

Playground

@Azure.ClientGenerator.Core.Legacy.markAsLro
get is Extension.Read<
  Extension.ScopeParameter,
  Employee,
  Response = ArmResponse<Employee> | ArmAcceptedResponse,
  Error = ErrorResponse
>;

Actual: TCGC throws error
Expected: lroMatadata returns correctly

Case 2: response 200 with body and 202 with body too

Real case in web.

Playground.

@Azure.ClientGenerator.Core.Legacy.markAsLro
  getProductionSiteDeploymentStatus is CsmDeploymentStatusOps.Read<
    Employee,
     Response = ArmResponse<Employee> | ArmAcceptedResponse & Employee
  >;

Actual: finalStateVia: original-uri
Expected: finalStateVia: location

[markcowl]

I believe this is expected, as you need to exclude the retryAfter header that occurs in ArmAcceptedResponse (AcceptedResponse should work, as here)

and here

[pshao25]

@markcowl Your first link throws the same error. Notice that it is TCGC throwing error, not autorest. Your second link gives the unexpected finalStateVia: original-uri as well.

@iscai-msft could you take a look?