Skip to content

Commit df82c45

Browse files
authored
Breakout rooms banner fix for react 17 and lower (#5358)
* Fix BreakoutRoomsBanner component to return null instead of undefined when there is no breakout room state * Change files
1 parent 3f04454 commit df82c45

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Breakout rooms",
5+
"comment": "Fix BreakoutRoomsBanner component to return null instead of undefined when there is no breakout room state",
6+
"packageName": "@azure/communication-react",
7+
"email": "79475487+mgamis-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Breakout rooms",
5+
"comment": "Fix BreakoutRoomsBanner component to return null instead of undefined when there is no breakout room state",
6+
"packageName": "@azure/communication-react",
7+
"email": "79475487+mgamis-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}

packages/react-composites/src/composites/CallComposite/components/BreakoutRoomsBanner.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { Banner } from './Banner';
2525
export const BreakoutRoomsBanner = (props: {
2626
locale: CompositeLocale;
2727
adapter: CommonCallAdapter;
28-
}): JSX.Element | undefined => {
28+
}): JSX.Element | null => {
2929
const { locale, adapter } = props;
3030

3131
const assignedBreakoutRoom = useSelector(getAssignedBreakoutRoom);
@@ -61,5 +61,5 @@ export const BreakoutRoomsBanner = (props: {
6161
</Stack>
6262
);
6363
}
64-
return undefined;
64+
return null;
6565
};

0 commit comments

Comments
 (0)