Apply service side prefiltering to azure files #3279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
dphulkar-msft,
gapra-msft,
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft,
vibhansa-msft and
wonwuakpa-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds prefix-based filtering optimization to Azure Files directory enumeration to improve scanning performance. The change enables service-side filtering using include patterns (e.g., --include-pattern "foo*" would apply a "foo" prefix) when listing files within each directory.
- Retrieves the enumeration pre-filter prefix from filters before enumerating directories
- Passes the prefix to the Azure Files API's
Prefixoption when non-empty - Aligns Azure Files traverser with blob traverser's optimization approach
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
As part of this PR can we confirm we have some tests for FileShare with filtering flags? |
gapra-msft
approved these changes
Nov 6, 2025
dphulkar-msft
approved these changes
Nov 7, 2025
wonwuakpa-msft
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature / Bug Fix: Gets prefilter similar to blob and applies it on non-recursive enumerations
Related Links:
PBI 34000420
Type of Change
How Has This Been Tested?
Manually tested; service side prefixes can be difficult to test.