Fix UUID generation to guarantee full buffer fill using rand.Read #3249
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The UUID generation code in
common/uuid.gowas usingrand.Reader.Read()to fill the UUID buffer with random bytes. However,io.Reader.Read()does not guarantee that the entire buffer will be filled - it can return a short read without an error, potentially leaving parts of the UUID buffer uninitialized.Solution
This PR replaces
rand.Reader.Read(uuid)withrand.Read(uuid)in theNewUUID()function.According to the Go documentation,
rand.Read():io.ReadFull()onrand.ReaderinternallyThis matches our existing error handling behavior and ensures the UUID buffer is always completely filled with random data.
Changes
File:
common/uuid.go_, err := rand.Reader.Read(uuid)to_, err := rand.Read(uuid)Testing
TestGUIDGenerationAndParsing)Fixes the issue raised in #[issue_number] regarding
rand.Reader.Readvsrand.Read.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.