Initial Private networking changes in AzCopy #3215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgv-msft
requested review from
otendolkar,
samskan and
shnayak-msft
as code owners
…ersisted on Remote FS (Azure File Share) 1. FdataSync + Fsync to flush the smb client cached data to the remote FS. 2. Avoids data coherency problem when plan files are memory mapped in STE. 3. Best effort - Unmapping of plan files and madvise(DONTNEED) of mmap'd memory to reduce inactive_file memory usage.
…ern/minio-client-09092025
otendolkar
reviewed
Sep 16, 2025
|
|
||
| if buildmode.IsMover { | ||
| StartSystemStatsMonitorForJob(jobID) | ||
| //StartSystemStatsMonitorForJob(jobID) |
Collaborator
There was a problem hiding this comment.
Why are we commenting this out?
Collaborator
There was a problem hiding this comment.
This we have commented out in c2c-stage branch itself.
We will enable it back once we move to mover/stage2.
I think we have enough memory stats from rolling stats that we log from main.go in worker.
otendolkar
reviewed
Sep 16, 2025
| Secure: true, | ||
| Transport: transport, | ||
| Region: credInfo.S3CredentialInfo.Region, | ||
| BucketLookup: minio.BucketLookupDNS, // force virtual-hosted style |
Collaborator
There was a problem hiding this comment.
How does this handle buckets that have naming conventions only compatible with path-style url?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature / Bug Fix: Initial changes for private networking for C2C.
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!