Skip to content

Conversation

@dphulkar-msft
Copy link
Member

@dphulkar-msft dphulkar-msft commented Aug 28, 2025

Description

This PR will be merged directly to main after all the NFS Phase-2 changes are merged to main to avoid merge conflicts.

  • Feature / Bug Fix: (Brief description of the feature or issue being addressed)

  • Related Links:

  • Issues

  • Team thread

  • Documents

  • [Email Subject]

Type of Change

  • Bug fix
  • New feature
  • Documentation update required
  • Code quality improvement
  • Other (describe):

How Has This Been Tested?

Thank you for your contribution to AzCopy!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors Azure Files location handling by introducing FileSMB as a replacement for File to differentiate SMB shares from NFS shares. This change addresses scenarios where separate handling is needed for SMB and NFS file share protocols.

  • Replaces common.ELocation.File() with common.ELocation.FileSMB() throughout the codebase
  • Updates fromTo mappings to use the new FileSMB location type
  • Maintains backward compatibility for existing file operations while enabling protocol-specific handling

Reviewed Changes

Copilot reviewed 54 out of 54 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
common/fe-ste-models.go Updates location definitions and fromTo mappings to replace File() with FileSMB()
ste/xfer.go Updates transfer logic to use FileSMB location for Azure Files operations
cmd/validators.go Updates URL inference logic to use FileSMB for file.core.windows.net endpoints
Various test files Updates test scenarios to use FileSMB location instead of File
Various STE files Updates transfer managers and processors to use FileSMB location

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dphulkar-msft dphulkar-msft changed the base branch from main to dphulkar/NFSOverRESTSupport August 28, 2025 13:08
@dphulkar-msft dphulkar-msft marked this pull request as draft September 2, 2025 07:04
@dphulkar-msft dphulkar-msft marked this pull request as ready for review September 4, 2025 13:08
@dphulkar-msft dphulkar-msft changed the title Introduce FileSMB/FileNFS for non File s2s or upload/download paths Update File() location with FileSMB() Sep 10, 2025
@dphulkar-msft dphulkar-msft marked this pull request as draft September 10, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants