-
Notifications
You must be signed in to change notification settings - Fork 250
Update File() location with FileSMB() #3193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dphulkar/NFSOverRESTSupport
Are you sure you want to change the base?
Update File() location with FileSMB() #3193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors Azure Files location handling by introducing FileSMB as a replacement for File to differentiate SMB shares from NFS shares. This change addresses scenarios where separate handling is needed for SMB and NFS file share protocols.
- Replaces
common.ELocation.File()withcommon.ELocation.FileSMB()throughout the codebase - Updates fromTo mappings to use the new FileSMB location type
- Maintains backward compatibility for existing file operations while enabling protocol-specific handling
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
common/fe-ste-models.go |
Updates location definitions and fromTo mappings to replace File() with FileSMB() |
ste/xfer.go |
Updates transfer logic to use FileSMB location for Azure Files operations |
cmd/validators.go |
Updates URL inference logic to use FileSMB for file.core.windows.net endpoints |
| Various test files | Updates test scenarios to use FileSMB location instead of File |
| Various STE files | Updates transfer managers and processors to use FileSMB location |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…e/azure-storage-azcopy into dphulkar/IntroduceFileSMB
Description
This PR will be merged directly to main after all the NFS Phase-2 changes are merged to main to avoid merge conflicts.
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!