[Storage] SAS PoC #2798
Draft
[Storage] SAS PoC #2798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,6 +83,32 @@ impl BlobClient { | |||
| }) | |||
| } | |||
|
|
|||
| pub fn new_no_credential( | |||
There was a problem hiding this comment.
Need to expose a way to construct a credential-less handwritten abstraction of the clients.
There was a problem hiding this comment.
- Make this
from_blob_url - Should take a full Blob URL, no
container_nameorblob_nameinput - Parse those elements out, pass along to generated layer
- For now, endpoint can still have query parameters
| @@ -102,6 +102,35 @@ impl BlobClient { | |||
| }) | |||
| } | |||
|
|
|||
| pub fn new_no_credential( | |||
There was a problem hiding this comment.
GEN CODE SUPPORT: Credential-less new() that also doesn't call endpoint.set_query(None) and clobbers all query params.
Comment on lines
+802
to
+810
| // let mut path = String::from("{containerName}/{blobName}"); | ||
| // path = path.replace("{blobName}", &self.blob_name); | ||
| // path = path.replace("{containerName}", &self.container_name); | ||
| // url = url.join(&path)?; | ||
| { | ||
| let mut path_segments = url.path_segments_mut().expect("Cannot be base"); | ||
| path_segments.push(&self.container_name); | ||
| path_segments.push(&self.blob_name); | ||
| } |
There was a problem hiding this comment.
This is a sample of the refactor on per-method -- need to use path_segments_mut() to append the path segments rather than using join() (which also was clobbering everything but the base)
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.