Skip to content

Add TryFrom implementations used in Spector tests #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

antkmsft
Copy link
Member

@antkmsft antkmsft commented Jul 14, 2025

The Spector test using the syntax: https://github.com/Azure/typespec-rust/pull/502

@LarryOsterman
Copy link
Member

I'm going to ask an ugly question: Do we really need to support a Decimal type for any scenarios other than Spector?

Could this be implemented using a decimal feature to make the dependency an optional dependency so we don't add this package (and its half dozen or so unique dependencies) to the SDK? That way service clients which need the Decimal type can add the typespec_client_core with the decimal feature but other clients won't have the overhead.

@antkmsft antkmsft marked this pull request as ready for review July 15, 2025 15:17
@antkmsft antkmsft requested a review from jhendrixMSFT July 15, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants