Skip to content

Update emitter to 0.19.0 #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

Update emitter to 0.19.0 #2822

merged 1 commit into from
Jul 28, 2025

Conversation

chlowell
Copy link
Member

No description provided.

@chlowell chlowell self-assigned this Jul 25, 2025
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Jul 25, 2025
@chlowell chlowell marked this pull request as ready for review July 25, 2025 23:07
@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 23:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @azure-tools/typespec-rust dependency from version 0.18.0 to 0.19.0 in the emitter package configuration.

  • Updates TypeSpec Rust tools dependency to version 0.19.0
Files not reviewed (1)
  • eng/emitter-package-lock.json: Language not supported

@LarryOsterman
Copy link
Member

Does this obsolete #2816?

Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM for Storage.

One aside, are the tracing names i.e.[tracing::function("Storage.Blob.Container.Blob.AppendBlob.appendBlock")] rendered as such, or how do they show up for the customer?

@LarryOsterman
Copy link
Member

Changes LGTM for Storage.

One aside, are the tracing names i.e.[tracing::function("Storage.Blob.Container.Blob.AppendBlob.appendBlock")] rendered as such, or how do they show up for the customer?

If the customer has enabled distributed tracing in their ClientOptions, then a public API span is created for the public APIs.

This can be overwritten for wrapped clients if necessary (and it may be necessary/desirable for storage clients). Longer term, the plan is to add a knob that client teams who write wrapped clients can switch to disable the distributed tracing macros in favor of client specific implementations. See this for more information on the distributed tracing infrastructure.

@chlowell
Copy link
Member Author

Does this obsolete #2816?

I suppose so, because it includes Storage crates. Sorry I didn't see #2816 before doing this

@LarryOsterman
Copy link
Member

Does this obsolete #2816?

I suppose so, because it includes Storage crates. Sorry I didn't see #2816 before doing this

Ok, closing #2816.

@chlowell chlowell merged commit 5f5e992 into Azure:main Jul 28, 2025
26 checks passed
@chlowell chlowell deleted the emitter-0.19 branch July 28, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants