Skip to content

Commit 0c724e3

Browse files
yoshuawuytsrylev
yoshuawuyts
and
rylev
authored
Squash warnings on main (#535)
* Add #[allow(unused)] in order to fix warnings We should gradually revert this PR and remove every single `#[allow(unused)]` call inserted. We did it this way in order to un-break the main branch. Co-Authored-By: Ryan Levick <rylev@users.noreply.github.com> * Apply first round of clippy fixes Co-Authored-By: Ryan Levick <rylev@users.noreply.github.com> * Apply second round of cargo clippy Co-Authored-By: Ryan Levick <rylev@users.noreply.github.com> * Apply cargo fmt Co-Authored-By: Ryan Levick <rylev@users.noreply.github.com> * fix rust flags on CI Co-Authored-By: Ryan Levick <rylev@users.noreply.github.com> * fix cargo doc warnings Co-Authored-By: Ryan Levick <rylev@users.noreply.github.com> * fix unused code Co-Authored-By: Ryan Levick <rylev@users.noreply.github.com> * add cargo doc to CI Co-Authored-By: Ryan Levick <rylev@users.noreply.github.com> * squash mock transport warnings Co-Authored-By: Ryan Levick <rylev@users.noreply.github.com> * fix accidental test breakage Co-Authored-By: Ryan Levick <rylev@users.noreply.github.com> * fix unused field in generated code Co-Authored-By: Ryan Levick <rylev@users.noreply.github.com> Co-authored-by: Ryan Levick <rylev@users.noreply.github.com>
1 parent 7ac58a2 commit 0c724e3

40 files changed

+99
-207
lines changed

‎.github/workflows/build.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
push:
66

77
env:
8-
RUSTFLAGS: --deny warnings --allow unused_attributes
8+
RUSTFLAGS: -Dwarnings
99
CARGO_INCREMENTAL: 0
1010

1111
jobs:
@@ -29,6 +29,9 @@ jobs:
2929
- name: cargo clippy sdk
3030
run: cargo clippy --all
3131

32+
- name: cargo doc sdk
33+
run: cargo doc --all
34+
3235
- name: cargo fmt services
3336
run: |
3437
./eng/scripts/check_json_format.sh

‎.github/workflows/services-all-features.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
workflow_dispatch:
55

66
env:
7-
RUSTFLAGS: --deny warnings --allow unused_attributes --allow unreachable-code --allow unused-assignments
7+
RUSTFLAGS: -Dwarnings
88
CARGO_INCREMENTAL: 0
99

1010
jobs:

‎sdk/core/src/incompletevector.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ mod test {
4848
let v = vec![0, 1, 2, 3, 4, 5];
4949
let ic = IncompleteVector::new(None, v);
5050

51-
assert_eq!(ic.is_complete(), true);
51+
assert!(ic.is_complete());
5252
}
5353

5454
#[test]
5555
fn test_incomplete_vector_incomplete() {
5656
let v = vec![0, 1, 2, 3, 4, 5];
5757
let ic = IncompleteVector::new(Some("aaa".into()), v);
5858

59-
assert_eq!(ic.is_complete(), false);
59+
assert!(!ic.is_complete());
6060
}
6161

6262
#[test]

‎sdk/core/src/options.rs

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ use std::time::Duration;
1515
/// .retry(RetryOptions::default().max_retries(10u32))
1616
/// .telemetry(TelemetryOptions::default().application_id("my-application"));
1717
/// ```
18-
#[derive(Clone, Debug)]
18+
#[derive(Clone, Debug, Default)]
1919
pub struct ClientOptions {
2020
// TODO: Expose transport override.
2121
/// Policies called per call.
@@ -34,18 +34,6 @@ pub struct ClientOptions {
3434
pub(crate) transport: TransportOptions,
3535
}
3636

37-
impl Default for ClientOptions {
38-
fn default() -> Self {
39-
Self {
40-
per_call_policies: Vec::new(),
41-
per_retry_policies: Vec::new(),
42-
retry: RetryOptions::default(),
43-
telemetry: TelemetryOptions::default(),
44-
transport: TransportOptions::default(),
45-
}
46-
}
47-
}
48-
4937
impl ClientOptions {
5038
pub fn new() -> Self {
5139
Self::default()

‎sdk/core/src/pipeline.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ use std::sync::Arc;
2525
/// A pipeline is immutable. In other words a policy can either succeed and call the following
2626
/// policy of fail and return to the calling policy. Arbitrary policy "skip" must be avoided (but
2727
/// cannot be enforced by code). All policies except Transport policy can assume there is another following policy (so
28-
/// self.pipeline[0] is always valid).
28+
/// `self.pipeline[0]` is always valid).
2929
///
3030
/// The `C` generic contains the pipeline-specific context. Different crates can pass
3131
/// different contexts using this generic. This way each crate can have its own specific pipeline

‎sdk/core/src/policies/mock_transport_player_policy.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ use std::sync::Arc;
66

77
#[derive(Debug, Clone)]
88
pub struct MockTransportPlayerPolicy {
9+
#[allow(unused)]
910
pub(crate) transport_options: TransportOptions,
1011
transaction: MockTransaction,
1112
}

‎sdk/core/src/policies/transport.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ use std::sync::Arc;
99

1010
#[derive(Debug, Clone)]
1111
pub struct TransportPolicy {
12+
#[allow(unused)]
1213
pub(crate) transport_options: TransportOptions,
1314
}
1415

‎sdk/cosmos/src/clients/collection_client.rs

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,7 @@ impl CollectionClient {
5353

5454
let response = self
5555
.pipeline()
56-
.send(
57-
&mut ctx.clone().insert(ResourceType::Collections),
58-
&mut request,
59-
)
56+
.send(ctx.clone().insert(ResourceType::Collections), &mut request)
6057
.await?;
6158

6259
Ok(GetCollectionResponse::try_from(response).await?)
@@ -74,10 +71,7 @@ impl CollectionClient {
7471

7572
let response = self
7673
.pipeline()
77-
.send(
78-
&mut ctx.clone().insert(ResourceType::Collections),
79-
&mut request,
80-
)
74+
.send(ctx.clone().insert(ResourceType::Collections), &mut request)
8175
.await?;
8276

8377
Ok(DeleteCollectionResponse::try_from(response).await?)
@@ -95,10 +89,7 @@ impl CollectionClient {
9589

9690
let response = self
9791
.pipeline()
98-
.send(
99-
&mut ctx.clone().insert(ResourceType::Collections),
100-
&mut request,
101-
)
92+
.send(ctx.clone().insert(ResourceType::Collections), &mut request)
10293
.await?;
10394

10495
Ok(ReplaceCollectionResponse::try_from(response).await?)
@@ -121,10 +112,7 @@ impl CollectionClient {
121112
options.decorate_request(&mut request, document)?;
122113
let response = self
123114
.pipeline()
124-
.send(
125-
&mut ctx.clone().insert(ResourceType::Documents),
126-
&mut request,
127-
)
115+
.send(ctx.clone().insert(ResourceType::Documents), &mut request)
128116
.await?;
129117

130118
Ok(CreateDocumentResponse::try_from(response).await?)

‎sdk/cosmos/src/clients/cosmos_client.rs

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ pub struct CosmosClient {
3535
}
3636

3737
/// Options for specifying how a Cosmos client will behave
38-
#[derive(Debug, Clone)]
38+
#[derive(Debug, Clone, Default)]
3939
pub struct CosmosOptions {
4040
options: ClientOptions,
4141
}
@@ -55,14 +55,6 @@ impl CosmosOptions {
5555
}
5656
}
5757

58-
impl Default for CosmosOptions {
59-
fn default() -> Self {
60-
Self {
61-
options: Default::default(),
62-
}
63-
}
64-
}
65-
6658
/// Create a Pipeline from CosmosOptions
6759
fn new_pipeline_from_options(
6860
options: CosmosOptions,
@@ -188,10 +180,7 @@ impl CosmosClient {
188180
options.decorate_request(&mut request, database_name.as_ref())?;
189181
let response = self
190182
.pipeline()
191-
.send(
192-
&mut ctx.clone().insert(ResourceType::Databases),
193-
&mut request,
194-
)
183+
.send(ctx.clone().insert(ResourceType::Databases), &mut request)
195184
.await?;
196185

197186
Ok(CreateDatabaseResponse::try_from(response).await?)
@@ -233,10 +222,7 @@ impl CosmosClient {
233222
r#try!(options.decorate_request(&mut request).await);
234223
let response = r#try!(
235224
this.pipeline()
236-
.send(
237-
&mut ctx.clone().insert(ResourceType::Databases),
238-
&mut request
239-
)
225+
.send(ctx.clone().insert(ResourceType::Databases), &mut request)
240226
.await
241227
);
242228

@@ -250,10 +236,7 @@ impl CosmosClient {
250236
r#try!(continuation.add_as_header2(&mut request));
251237
let response = r#try!(
252238
this.pipeline()
253-
.send(
254-
&mut ctx.clone().insert(ResourceType::Databases),
255-
&mut request
256-
)
239+
.send(ctx.clone().insert(ResourceType::Databases), &mut request)
257240
.await
258241
);
259242
ListDatabasesResponse::try_from(response).await
@@ -353,6 +336,7 @@ impl CosmosClient {
353336
///
354337
/// All variants require the cosmos account name. `Custom` also requires a valid
355338
/// base URL (e.g. https://custom.documents.azure.com)
339+
#[allow(unused)]
356340
#[derive(Debug, Clone)]
357341
enum CloudLocation {
358342
/// Azure public cloud

‎sdk/cosmos/src/clients/database_client.rs

Lines changed: 7 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,7 @@ impl DatabaseClient {
6969
options.decorate_request(&mut request)?;
7070
let response = self
7171
.pipeline()
72-
.send(
73-
&mut ctx.clone().insert(ResourceType::Databases),
74-
&mut request,
75-
)
72+
.send(ctx.clone().insert(ResourceType::Databases), &mut request)
7673
.await?;
7774

7875
Ok(GetDatabaseResponse::try_from(response).await?)
@@ -92,10 +89,7 @@ impl DatabaseClient {
9289
options.decorate_request(&mut request)?;
9390
let response = self
9491
.pipeline()
95-
.send(
96-
&mut ctx.clone().insert(ResourceType::Databases),
97-
&mut request,
98-
)
92+
.send(ctx.clone().insert(ResourceType::Databases), &mut request)
9993
.await?;
10094

10195
Ok(DeleteDatabaseResponse::try_from(response).await?)
@@ -122,10 +116,7 @@ impl DatabaseClient {
122116
r#try!(options.decorate_request(&mut request));
123117
let response = r#try!(
124118
this.pipeline()
125-
.send(
126-
&mut ctx.clone().insert(ResourceType::Collections),
127-
&mut request
128-
)
119+
.send(ctx.clone().insert(ResourceType::Collections), &mut request)
129120
.await
130121
);
131122
ListCollectionsResponse::try_from(response).await
@@ -141,10 +132,7 @@ impl DatabaseClient {
141132
r#try!(continuation.add_as_header2(&mut request));
142133
let response = r#try!(
143134
this.pipeline()
144-
.send(
145-
&mut ctx.clone().insert(ResourceType::Collections),
146-
&mut request
147-
)
135+
.send(ctx.clone().insert(ResourceType::Collections), &mut request)
148136
.await
149137
);
150138
ListCollectionsResponse::try_from(response).await
@@ -180,10 +168,7 @@ impl DatabaseClient {
180168
options.decorate_request(&mut request, collection_name.as_ref())?;
181169
let response = self
182170
.pipeline()
183-
.send(
184-
&mut ctx.clone().insert(ResourceType::Collections),
185-
&mut request,
186-
)
171+
.send(ctx.clone().insert(ResourceType::Collections), &mut request)
187172
.await?;
188173

189174
Ok(CreateCollectionResponse::try_from(response).await?)
@@ -210,7 +195,7 @@ impl DatabaseClient {
210195
r#try!(options.decorate_request(&mut request));
211196
let response = r#try!(
212197
this.pipeline()
213-
.send(&mut ctx.clone().insert(ResourceType::Users), &mut request)
198+
.send(ctx.clone().insert(ResourceType::Users), &mut request)
214199
.await
215200
);
216201
ListUsersResponse::try_from(response).await
@@ -226,7 +211,7 @@ impl DatabaseClient {
226211
r#try!(continuation.add_as_header2(&mut request));
227212
let response = r#try!(
228213
this.pipeline()
229-
.send(&mut ctx.clone().insert(ResourceType::Users), &mut request)
214+
.send(ctx.clone().insert(ResourceType::Users), &mut request)
230215
.await
231216
);
232217
ListUsersResponse::try_from(response).await

0 commit comments

Comments
 (0)