Staging signoff fixes #42266
Open
Staging signoff fixes #42266
+193
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - cosmos - tests |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses staging signoff fixes with a focus on making tests work with actual account locations and fixing a bug where metadata requests were not honoring excluded locations. The changes primarily involve:
- Updating test configuration to dynamically retrieve and use actual account locations instead of hardcoded values
- Fixing metadata request handling to properly respect excluded locations for session container, queries, and partition key range operations
- Various test fixes and improvements including async client initialization and error message formatting
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
test_config.py |
Added dynamic account location retrieval and populated class attributes |
conftest.py |
Added call to populate account info during test session setup |
| Multiple test files | Updated to use dynamic locations from TestConfig instead of hardcoded values |
_session.py |
Updated session token methods to accept and pass excluded locations options |
_routing/routing_map_provider.py |
Made feed_options parameter required for proper excluded locations handling |
_base.py |
Updated session token header setting to pass options parameter |
_global_partition_endpoint_manager_circuit_breaker.py |
Fixed excluded locations handling in partition key range operations |
| Multiple execution context files | Updated to pass options parameter to routing provider calls |
_constants.py |
Added EXCLUDED_LOCATIONS constant |
CHANGELOG.md |
Documented the excluded locations bug fix |
Comments suppressed due to low confidence (1)
sdk/cosmos/azure-cosmos/azure/cosmos/_routing/aio/routing_map_provider.py
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
simorenoh
reviewed
Aug 1, 2025
| @@ -29,7 +29,7 @@ class TestQuery(unittest.TestCase): | |||
| connectionPolicy = config.connectionPolicy | |||
| TEST_DATABASE_ID = config.TEST_DATABASE_ID | |||
| is_emulator = config.is_emulator | |||
| credential = config.credential | |||
| credential = config.masterKey | |||
There was a problem hiding this comment.
was this broken for AAD? same question for the same changes elsewhere
There was a problem hiding this comment.
I will create a separate live tests pipeline running many of the tests in AAD in separate pr. This will also make it easier to filter them out for staging pipeline. For now, moved everything back to using keys.
simorenoh
approved these changes
Aug 1, 2025
…on3/azure-sdk-for-python into tvaron3/stagingSignoffFixes
…into tvaron3/stagingSignoffFixes # Conflicts: # sdk/cosmos/azure-cosmos/tests/workloads/dev.md # sdk/cosmos/azure-cosmos/tests/workloads/workload_configs.py # sdk/cosmos/azure-cosmos/tests/workloads/workload_utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description