Skip to content

Commit e039cb4

Browse files
nagkumar91Nagkumar ArkalgudNagkumar Arkalgud
authored
Change evaluator ID (#41855)
* Prepare evals SDK Release * Fix bug * Fix for ADV_CONV for FDP projects * Update release date * re-add pyrit to matrix * Change grader ids * Update unit test * replace all old grader IDs in tests * Update platform-matrix.json Add pyrit and not remove the other one * Update test to ensure everything is mocked * tox/black fixes * Skip that test with issues * update grader ID according to API View feedback * Update test * remove string check for grader ID --------- Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalg-work-mac.local> Co-authored-by: Nagkumar Arkalgud <nagkumar@Mac.lan>
1 parent e2c7c0d commit e039cb4

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_aoai/score_model_grader.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class AzureOpenAIScoreModelGrader(AzureOpenAIGrader):
4747
:type kwargs: Any
4848
"""
4949

50-
id = "azureai://built-in/evaluators/azure-openai/scorer_grader"
50+
id = "azureai://built-in/evaluators/azure-openai/score_model_grader"
5151

5252
def __init__(
5353
self,

sdk/evaluation/azure-ai-evaluation/tests/unittests/test_aoai_score_model_grader.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -234,13 +234,6 @@ def test_different_score_ranges(self, mock_aoai_model_config):
234234
assert grader._grader_config.range == [0.0, 10.0]
235235
assert grader.pass_threshold == 5.0 # Midpoint default
236236

237-
def test_grader_id_property(self, mock_aoai_model_config, basic_score_grader_config):
238-
"""Test that grader has correct ID."""
239-
grader = AzureOpenAIScoreModelGrader(model_config=mock_aoai_model_config, **basic_score_grader_config)
240-
241-
assert grader.id == "azureai://built-in/evaluators/azure-openai/scorer_grader"
242-
assert AzureOpenAIScoreModelGrader.id == "azureai://built-in/evaluators/azure-openai/scorer_grader"
243-
244237
@patch("azure.ai.evaluation._aoai.score_model_grader.AzureOpenAIGrader.get_client")
245238
def test_grader_with_mocked_client(self, mock_get_client, mock_aoai_model_config, basic_score_grader_config):
246239
"""Test grader creation and basic properties with mocked client."""
@@ -251,7 +244,7 @@ def test_grader_with_mocked_client(self, mock_get_client, mock_aoai_model_config
251244
grader = AzureOpenAIScoreModelGrader(model_config=mock_aoai_model_config, **basic_score_grader_config)
252245

253246
assert grader is not None
254-
assert grader.id == "azureai://built-in/evaluators/azure-openai/scorer_grader"
247+
assert grader.id == AzureOpenAIScoreModelGrader.id
255248
assert hasattr(grader, "pass_threshold")
256249
assert grader.pass_threshold == 0.5
257250

@@ -956,4 +949,3 @@ def test_grader_with_client_initialization_error(self, mock_get_client, mock_aoa
956949
)
957950

958951
assert grader is not None
959-
assert grader.id == "azureai://built-in/evaluators/azure-openai/scorer_grader"

0 commit comments

Comments
 (0)