Skip to content

Commit d8bcdc5

Browse files
fix v1 tests where we don't return finish_details anymore (#33514)
1 parent 3bd5d0a commit d8bcdc5

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

sdk/openai/azure-openai/tests/v1_tests/test_chat_completions.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1044,7 +1044,7 @@ def test_chat_completion_vision(self, client, azure_openai_creds, api_type, **kw
10441044
{"type": "text", "text": "What's in this image?"},
10451045
{
10461046
"type": "image_url",
1047-
"image_url": "https://upload.wikimedia.org/wikipedia/commons/thumb/f/f9/Rainier20200906.jpg/1920px-Rainier20200906.jpg",
1047+
"image_url": "https://learn.microsoft.com/en-us/azure/ai-services/computer-vision/images/handwritten-note.jpg",
10481048
},
10491049
],
10501050
}
@@ -1058,7 +1058,6 @@ def test_chat_completion_vision(self, client, azure_openai_creds, api_type, **kw
10581058
assert completion.usage.prompt_tokens is not None
10591059
assert completion.usage.total_tokens == completion.usage.completion_tokens + completion.usage.prompt_tokens
10601060
assert len(completion.choices) == 1
1061-
assert completion.choices[0].finish_details is not None
10621061
assert completion.choices[0].index is not None
10631062
assert completion.choices[0].message.content is not None
10641063
assert completion.choices[0].message.role

sdk/openai/azure-openai/tests/v1_tests/test_chat_completions_async.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1066,7 +1066,7 @@ async def test_chat_completion_vision(self, client_async, azure_openai_creds, ap
10661066
{"type": "text", "text": "What's in this image?"},
10671067
{
10681068
"type": "image_url",
1069-
"image_url": "https://upload.wikimedia.org/wikipedia/commons/thumb/f/f9/Rainier20200906.jpg/1920px-Rainier20200906.jpg",
1069+
"image_url": "https://learn.microsoft.com/en-us/azure/ai-services/computer-vision/images/handwritten-note.jpg",
10701070
},
10711071
],
10721072
}
@@ -1080,7 +1080,6 @@ async def test_chat_completion_vision(self, client_async, azure_openai_creds, ap
10801080
assert completion.usage.prompt_tokens is not None
10811081
assert completion.usage.total_tokens == completion.usage.completion_tokens + completion.usage.prompt_tokens
10821082
assert len(completion.choices) == 1
1083-
assert completion.choices[0].finish_details is not None
10841083
assert completion.choices[0].index is not None
10851084
assert completion.choices[0].message.content is not None
10861085
assert completion.choices[0].message.role

0 commit comments

Comments
 (0)