-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Pushing Swagger into Azure SPEC for MS-Learn #35874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pushing Swagger into Azure SPEC for MS-Learn #35874
Conversation
This comment is a remnant of a now-deprecated bot framework. It is being left behind only to point at the new comment that is updated by our new actions-based framework. |
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
…into users/V-apolepalli/TypeSpec
…KumarPolepalli/azure-rest-api-specs into users/V-apolepalli/TypeSpec
…into users/V-apolepalli/TypeSpec
…KumarPolepalli/azure-rest-api-specs into users/V-apolepalli/TypeSpec
- tool: TypeSpecValidation | ||
paths: | ||
# Specify the path to the tspconfig.yaml file where suppression should apply | ||
- .\azure-rest-api-specs\specification\purviewdatagovernance\purviewdatacatalog\tspconfig.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path is relative to this suppressions.yaml file
Deferring to the SDK team on the matter of folder structure.
PR Summary for recent commits:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of the four examples and readme file in the
specification/purviewdatagovernance/data-plane/PurviewUnifiedCatalog/preview/2025-09-15-preview
directory? Is this a mistake? Should they actually be in
specification/purviewdatagovernance/data-plane/Azure.Analytics.Purview.UnifiedCatalog/preview/2025-09-15-preview
??
@AnilKumarPolepalli - the CLA check continues to fail, which means you have failed to configure your GitHub account properly. It would appear your Microsoft org membership is not public. Please follow the instructions here: https://eng.ms/docs/products/azure-developer-experience/onboard/access |
Not sure how its added and its older path; its removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking only at the REST API definition, this looks okay for preview.
Hi @benbp, @weshaggard, @maririos, @praveenkuttappan, @Azure/azure-sdk-eng could you please review this PR? It’s waiting for your approval to merge |
|
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you arent shipping Azure-branded client libraries, we should remove the entries for the language emitters in this file. Just keep the typespec-autorest entry for now. You might need to fix the suppressions file after removing these entries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed entries for language emitters in tspconfig file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this doc about how to suppress the sdk validation rule: https://github.com/Azure/azure-rest-api-specs/wiki/TypeSpec-Validation#suppressing-sdktspconfigvalidation-rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks for sharing the link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tspconfig.yaml file change and suppressions lgtm because this is not an Azure service per offline discussion. cc @lfraleigh
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.