Skip to content

Fix warnings in the repository #4320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
liliankasem opened this issue Mar 19, 2025 · 3 comments · Fixed by #4386, #4365, #4387 or #4380
Closed
3 tasks done

Fix warnings in the repository #4320

liliankasem opened this issue Mar 19, 2025 · 3 comments · Fixed by #4386, #4365, #4387 or #4380
Assignees
@liliankasem @VineethReyya
Labels
area: engineering Engineering improvements core-tools Needs: Attention 👋
Milestone
Core Tools 0

Comments

@liliankasem
Copy link
Member

liliankasem commented Mar 19, 2025 •
edited
Loading

Build.csproj and test/ projects can be ignored for now.

There will be a lot of file changes so this should be done incrementally over several PRs (maybe 30 files per PR max).

  • Func project
  • Host project
  • Artifact Assembler Project
@liliankasem liliankasem added the area: engineering Engineering improvements label Mar 19, 2025
@aishwaryabh
Copy link
Contributor

aishwaryabh commented Apr 4, 2025 •
edited by liliankasem
Loading

Note that this should be done in the feature/foundation branch until this PR gets merged in.

Edit: foundation has been merged, please use the main branch

@VineethReyya VineethReyya linked a pull request Apr 7, 2025 that will close this issue
4320 enable warnings as errors and fix any issues #4351
Closed
5 tasks
@VineethReyya VineethReyya mentioned this issue Apr 7, 2025
Closed
5 tasks
@VineethReyya VineethReyya linked a pull request Apr 15, 2025 that will close this issue
Fix warnings in solution (excluding build csproj) #4365
Merged
5 tasks
@VineethReyya VineethReyya mentioned this issue Apr 15, 2025
Merged
5 tasks
@liliankasem liliankasem changed the title Enable warnings as errors and fix any issues Fix warnings in the repository Apr 16, 2025
@liliankasem liliankasem reopened this Apr 16, 2025
@VineethReyya
Copy link
Contributor

@liliankasem, I wanted to check in regarding issue (assigned to me). Let me know if there's anything I need to do on my end to move this forward.

@liliankasem
Copy link
Member Author

@VineethReyya Can you fix the style issues in these projects:

  • Core tools host
  • Artifact assembler

@VineethReyya VineethReyya linked a pull request Apr 23, 2025 that will close this issue
Fix style in ArtifactAssembler project #4386
Merged
5 tasks
@VineethReyya VineethReyya removed a link to a pull request Apr 23, 2025
Fix warnings in solution (excluding build csproj) #4365
Merged
5 tasks
@VineethReyya VineethReyya linked a pull request Apr 23, 2025 that will close this issue
Fix warnings in solution (excluding build csproj) #4365
Merged
5 tasks
@VineethReyya VineethReyya removed a link to a pull request Apr 23, 2025
4320 enable warnings as errors and fix any issues #4351
Closed
5 tasks
@VineethReyya VineethReyya linked a pull request Apr 24, 2025 that will close this issue
Fix style in coretoolhost Project #4387
Merged
5 tasks
@VineethReyya VineethReyya mentioned this issue Apr 24, 2025
Merged
5 tasks
This was referenced Apr 24, 2025
Merged
Merged
@liliankasem liliankasem self-assigned this Apr 24, 2025
@VineethReyya VineethReyya reopened this Apr 28, 2025
@VineethReyya VineethReyya reopened this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liliankasem liliankasem

@VineethReyya VineethReyya

Labels
area: engineering Engineering improvements core-tools Needs: Attention 👋
Projects
None yet
Milestone
Core Tools 0
3 participants
@liliankasem @aishwaryabh @VineethReyya