add creator unit tests for releases, product policies, and api names given revisions

Author: lucashuet93

src/APIM_ARMTemplate/apimtemplate.test/Creator/TemplateCreatorFactories/APITemplateCreatorFactory.cs

@@ -12,7 +12,8 @@ public static APITemplateCreator GenerateAPITemplateCreator()
             PolicyTemplateCreator policyTemplateCreator = new PolicyTemplateCreator(fileReader);
             ProductAPITemplateCreator productAPITemplateCreator = new ProductAPITemplateCreator();
             DiagnosticTemplateCreator diagnosticTemplateCreator = new DiagnosticTemplateCreator();
-            APITemplateCreator apiTemplateCreator = new APITemplateCreator(fileReader, policyTemplateCreator, productAPITemplateCreator, diagnosticTemplateCreator);
+            ReleaseTemplateCreator releaseTemplateCreator = new ReleaseTemplateCreator();
+            APITemplateCreator apiTemplateCreator = new APITemplateCreator(fileReader, policyTemplateCreator, productAPITemplateCreator, diagnosticTemplateCreator, releaseTemplateCreator);
             return apiTemplateCreator;
         }
     }

src/APIM_ARMTemplate/apimtemplate.test/Creator/TemplateCreatorTests/APITemplateCreatorTests.cs

@@ -3,6 +3,7 @@
 using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common;
 using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create;
 using System.Collections.Generic;
+using System.Linq;
 
 namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Test
 {
@@ -140,6 +141,32 @@ public async void ShouldCreateUnifiedAPITemplateResourceFromCreatorConfig()
             Assert.Equal(api.openApiSpec, apiTemplateResource.properties.value);
         }
 
+        [Fact]
+        public async void ShouldAppendRevisionToAPIName()
+        {
+            // arrange
+            APITemplateCreator apiTemplateCreator = APITemplateCreatorFactory.GenerateAPITemplateCreator();
+            CreatorConfig creatorConfig = new CreatorConfig() { apis = new List<APIConfig>() };
+            APIConfig api = new APIConfig()
+            {
+                name = "name",
+                apiRevision = "2",
+                isCurrent = true,
+                suffix = "suffix",
+                subscriptionRequired = true,
+                openApiSpec = "https://petstore.swagger.io/v2/swagger.json",
+            };
+            creatorConfig.apis.Add(api);
+
+            // act
+            // the above api config will create a unified api template with a single resource
+            List<Template> apiTemplates = await apiTemplateCreator.CreateAPITemplatesAsync(api);
+            APITemplateResource apiTemplateResource = apiTemplates.FirstOrDefault().resources[0] as APITemplateResource;
+
+            // assert
+            Assert.Contains(";rev", apiTemplateResource.name);
+        }
+
         [Fact]
         public void ShouldCreateProtocolsFromOpenApiDocument()
         {

src/APIM_ARMTemplate/apimtemplate.test/Creator/TemplateCreatorTests/PolicyTemplateCreatorTests.cs

@@ -31,6 +31,37 @@ public void ShouldCreateAPIPolicyTemplateResourceFromCreatorConfigWithCorrectCon
             Assert.Equal(dependsOn, policyTemplateResource.dependsOn);
         }
 
+        [Fact]
+        public void ShouldCreateProductPolicyTemplateResourceFromCreatorConfigWithCorrectContent()
+        {
+            // arrange
+            PolicyTemplateCreator policyTemplateCreator = PolicyTemplateCreatorFactory.GeneratePolicyTemplateCreator();
+            CreatorConfig creatorConfig = new CreatorConfig() { products = new List<ProductConfig>() };
+            ProductConfig product = new ProductConfig()
+            {
+                displayName = "displayName",
+                description = "description",
+                terms = "terms",
+                subscriptionRequired = true,
+                approvalRequired = true,
+                subscriptionsLimit = 1,
+                state = "state",
+                policy = "http://someurl.com"
+
+            };
+            creatorConfig.products.Add(product);
+            string[] dependsOn = new string[] { "dependsOn" };
+
+            // act
+            PolicyTemplateResource policyTemplateResource = policyTemplateCreator.CreateProductPolicyTemplateResource(product, dependsOn);
+
+            // assert
+            Assert.Equal($"[concat(parameters('ApimServiceName'), '/{product.displayName}/policy')]", policyTemplateResource.name);
+            Assert.Equal("rawxml-link", policyTemplateResource.properties.format);
+            Assert.Equal(product.policy, policyTemplateResource.properties.value);
+            Assert.Equal(dependsOn, policyTemplateResource.dependsOn);
+        }
+
         [Fact]
         public void ShouldCreateOperationPolicyTemplateResourceFromPairWithCorrectContent()
         {

src/APIM_ARMTemplate/apimtemplate.test/Creator/TemplateCreatorTests/ProductTemplateCreatorTests.cs

@@ -21,14 +21,13 @@ public void ShouldCreateProductFromCreatorConfig()
                 subscriptionRequired = true,
                 approvalRequired = true,
                 subscriptionsLimit = 1,
-                state = "state",
-                policy = "<inbound></inbound>"
+                state = "state"
             };
             creatorConfig.products.Add(product);
 
             // act
-            Template loggerTemplate = productTemplateCreator.CreateProductTemplate(creatorConfig);
-            ProductsTemplateResource productsTemplateResource = (ProductsTemplateResource)loggerTemplate.resources[0];
+            Template productTemplate = productTemplateCreator.CreateProductTemplate(creatorConfig);
+            ProductsTemplateResource productsTemplateResource = (ProductsTemplateResource)productTemplate.resources[0];
 
             // assert
             Assert.Equal($"[concat(parameters('ApimServiceName'), '/{product.displayName}')]", productsTemplateResource.name);

src/APIM_ARMTemplate/apimtemplate.test/Creator/TemplateCreatorTests/ReleaseTemplateCreatorTests.cs

@@ -0,0 +1,39 @@
+using Xunit;
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common;
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Create;
+using System.Collections.Generic;
+
+namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Test
+{
+    public class ReleaseTemplateCreatorTests
+    {
+        [Fact]
+        public void ShouldCreateReleaseTemplateResourceFromCreatorConfig()
+        {
+            // arrange
+            ReleaseTemplateCreator releaseTemplateCreator = new ReleaseTemplateCreator();
+            CreatorConfig creatorConfig = new CreatorConfig() { apis = new List<APIConfig>() };
+            APIConfig api = new APIConfig()
+            {
+                name = "name",
+                apiRevision = "2",
+                isCurrent = true,
+                suffix = "suffix",
+                subscriptionRequired = true,
+                openApiSpec = "https://petstore.swagger.io/v2/swagger.json",
+            };
+            creatorConfig.apis.Add(api);
+
+            // act
+            string[] dependsOn = new string[] { "dependsOn" };
+            ReleaseTemplateResource releaseTemplateResource = releaseTemplateCreator.CreateAPIReleaseTemplateResource(api, dependsOn);
+
+            // assert
+            string releaseName = $"";
+            Assert.Equal($"[concat(parameters('ApimServiceName'), '/{api.name}/release-revision-{api.apiRevision}')]", releaseTemplateResource.name);
+            Assert.Equal(dependsOn, releaseTemplateResource.dependsOn);
+            Assert.Equal($"Release created to make revision {api.apiRevision} current.", releaseTemplateResource.properties.notes);
+            Assert.Equal($"[resourceId('Microsoft.ApiManagement/service/apis', parameters('ApimServiceName'), '{api.name}')]", releaseTemplateResource.properties.apiId);
+        }
+    }
+}