Merge pull request #246 from bremnes/242-arm-escape-sample-value

Correcting to valid ARM code if operation sample value is json array

Author: miaojiang

src/APIM_ARMTemplate/apimtemplate/Extractor/EntityExtractors/APIExtractor.cs

@@ -192,35 +192,23 @@ public async Task<Template> GenerateAPIsARMTemplateAsync(string apimname, string
                     operationResource.apiVersion = GlobalConstants.APIVersion;
                     operationResource.scale = null;
 
-                    // add api and schemas to operation dependsOn, if necessary
+                    // add operation dependencies and fix sample value if necessary
                     List<string> operationDependsOn = new List<string>() { $"[resourceId('Microsoft.ApiManagement/service/apis', parameters('ApimServiceName'), '{oApiName}')]" };
                     foreach (OperationTemplateRepresentation operationTemplateRepresentation in operationResource.properties.request.representations)
                     {
-                        if (operationTemplateRepresentation.schemaId != null)
-                        {
-                            string dependsOn = $"[resourceId('Microsoft.ApiManagement/service/apis/schemas', parameters('ApimServiceName'), '{oApiName}', '{operationTemplateRepresentation.schemaId}')]";
-                            // add value to list if schema has not already been added
-                            if (!operationDependsOn.Exists(o => o == dependsOn))
-                            {
-                                operationDependsOn.Add(dependsOn);
-                            }
-                        }
+                        AddSchemaDependencyToOperationIfNecessary(oApiName, operationDependsOn, operationTemplateRepresentation);
+                        ArmEscapeSampleValueIfNecessary(operationTemplateRepresentation);
                     }
+
                     foreach (OperationsTemplateResponse operationTemplateResponse in operationResource.properties.responses)
                     {
                         foreach (OperationTemplateRepresentation operationTemplateRepresentation in operationTemplateResponse.representations)
                         {
-                            if (operationTemplateRepresentation.schemaId != null)
-                            {
-                                string dependsOn = $"[resourceId('Microsoft.ApiManagement/service/apis/schemas', parameters('ApimServiceName'), '{oApiName}', '{operationTemplateRepresentation.schemaId}')]";
-                                // add value to list if schema has not already been added
-                                if (!operationDependsOn.Exists(o => o == dependsOn))
-                                {
-                                    operationDependsOn.Add(dependsOn);
-                                }
-                            }
+                            AddSchemaDependencyToOperationIfNecessary(oApiName, operationDependsOn, operationTemplateRepresentation);
+                            ArmEscapeSampleValueIfNecessary(operationTemplateRepresentation);
                         }
                     }
+
                     operationResource.dependsOn = operationDependsOn.ToArray();
                     templateResources.Add(operationResource);
 
@@ -342,7 +330,28 @@ public async Task<Template> GenerateAPIsARMTemplateAsync(string apimname, string
             return armTemplate;
         }
 
-        public static JObject FormatoApi(string singleApiName, JObject oApi)
+        private static void ArmEscapeSampleValueIfNecessary(OperationTemplateRepresentation operationTemplateRepresentation)
+        {
+            if (!string.IsNullOrWhiteSpace(operationTemplateRepresentation.sample) && operationTemplateRepresentation.contentType == "application/json" && JToken.Parse(operationTemplateRepresentation.sample).Type == JTokenType.Array)
+            {
+                operationTemplateRepresentation.sample = "[" + operationTemplateRepresentation.sample;
+            }
+        }
+
+        private static void AddSchemaDependencyToOperationIfNecessary(string oApiName, List<string> operationDependsOn, OperationTemplateRepresentation operationTemplateRepresentation)
+        {
+            if (operationTemplateRepresentation.schemaId != null)
+            {
+                string dependsOn = $"[resourceId('Microsoft.ApiManagement/service/apis/schemas', parameters('ApimServiceName'), '{oApiName}', '{operationTemplateRepresentation.schemaId}')]";
+                // add value to list if schema has not already been added
+                if (!operationDependsOn.Exists(o => o == dependsOn))
+                {
+                    operationDependsOn.Add(dependsOn);
+                }
+            }
+        }
+
+        private static JObject FormatoApi(string singleApiName, JObject oApi)
         {
             if (singleApiName != null)
             {
@@ -364,7 +373,7 @@ public static JObject FormatoApi(string singleApiName, JObject oApi)
             return oApi;
         }
 
-        public async Task<List<TemplateResource>> GenerateSchemasARMTemplate(string apimServiceName, string apiName, string resourceGroup, string fileFolder)
+        private async Task<List<TemplateResource>> GenerateSchemasARMTemplate(string apimServiceName, string apiName, string resourceGroup, string fileFolder)
         {
             List<TemplateResource> templateResources = new List<TemplateResource>();