Add clientcertificateId servicefabric backend property (#834)

levymuriuki · Levi Muriuki · web-flow · commit 6c222d02b61a · 2022-10-28T08:57:05.000-07:00
Co-authored-by: Levi Muriuki &lt;muriukilm@upmc.edu&gt;
diff --git a/src/ArmTemplates/Common/Constants/ResourceTypeConstants.cs b/src/ArmTemplates/Common/Constants/ResourceTypeConstants.cs
@@ -20,6 +20,7 @@ public static class ResourceTypeConstants
         public const string APISchema = "Microsoft.ApiManagement/service/apis/schemas";
         public const string AuthorizationServer = "Microsoft.ApiManagement/service/authorizationServers";
         public const string Backend = "Microsoft.ApiManagement/service/backends";
+        public const string Certificate = "Microsoft.ApiManagement/service/certificates";
         public const string GlobalServicePolicy = "Microsoft.ApiManagement/service/policies";
         public const string Logger = "Microsoft.ApiManagement/service/loggers";
         public const string ProductApi = "Microsoft.ApiManagement/service/products/apis";
diff --git a/src/ArmTemplates/Common/Templates/Backend/BackendServiceFabricCluster.cs b/src/ArmTemplates/Common/Templates/Backend/BackendServiceFabricCluster.cs
@@ -7,6 +7,7 @@ namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common.Templates
 {
     public class BackendServiceFabricCluster
     {
+        public string ClientCertificateId { get; set; }
         public string ClientCertificatethumbprint { get; set; }
         public int MaxPartitionResolutionRetries { get; set; }
         public string[] ManagementEndpoints { get; set; }
diff --git a/src/ArmTemplates/Creator/TemplateCreators/BackendTemplateCreator.cs b/src/ArmTemplates/Creator/TemplateCreators/BackendTemplateCreator.cs
@@ -36,6 +36,10 @@ public Template CreateBackendTemplate(CreatorParameters creatorConfig)
             List<TemplateResource> resources = new List<TemplateResource>();
             foreach (BackendTemplateProperties backendTemplatePropeties in creatorConfig.Backends)
             {
+                if (!string.IsNullOrWhiteSpace(backendTemplatePropeties.Properties?.ServiceFabricCluster?.ClientCertificateId)) {
+                    var clientCertId = backendTemplatePropeties.Properties.ServiceFabricCluster.ClientCertificateId;
+                    backendTemplatePropeties.Properties.ServiceFabricCluster.ClientCertificateId = $"[resourceId('{ResourceTypeConstants.Certificate}', parameters('{ParameterNames.ApimServiceName}'), '{clientCertId}')]";
+                }
                 // create backend resource with properties
                 BackendTemplateResource backendTemplateResource = new BackendTemplateResource()
                 {

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common.Templates`
`7`	`7`	`{`
`8`	`8`	`public class BackendServiceFabricCluster`
`9`	`9`	`{`
	`10`	`+ public string ClientCertificateId { get; set; }`
`10`	`11`	`public string ClientCertificatethumbprint { get; set; }`
`11`	`12`	`public int MaxPartitionResolutionRetries { get; set; }`
`12`	`13`	`public string[] ManagementEndpoints { get; set; }`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,10 @@ public Template CreateBackendTemplate(CreatorParameters creatorConfig)`
`36`	`36`	`List<TemplateResource> resources = new List<TemplateResource>();`
`37`	`37`	`foreach (BackendTemplateProperties backendTemplatePropeties in creatorConfig.Backends)`
`38`	`38`	`{`
	`39`	`+ if (!string.IsNullOrWhiteSpace(backendTemplatePropeties.Properties?.ServiceFabricCluster?.ClientCertificateId)) {`
	`40`	`+ var clientCertId = backendTemplatePropeties.Properties.ServiceFabricCluster.ClientCertificateId;`
	`41`	`+ backendTemplatePropeties.Properties.ServiceFabricCluster.ClientCertificateId = $"[resourceId('{ResourceTypeConstants.Certificate}', parameters('{ParameterNames.ApimServiceName}'), '{clientCertId}')]";`
	`42`	`+ }`
`39`	`43`	`// create backend resource with properties`
`40`	`44`	`BackendTemplateResource backendTemplateResource = new BackendTemplateResource()`
`41`	`45`	`{`