Creator: parameterize named values and secrets (#660)

* implement creator:parameterize named values + secrets + cleanup launchsettings

* provide full naming of parameters

* name parameters in multiple count (namedValueS)

Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com>

Author: DeagleGross

src/ArmTemplates/Commands/Applications/CreateApplicationCommand.cs

@@ -13,6 +13,7 @@
 using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Commands.Executors;
 using Microsoft.Extensions.Logging;
 using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common.Templates.Builders.Abstractions;
+using System.IO;
 
 namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Commands.Applications
 {
@@ -72,6 +73,12 @@ public async Task<CreatorConfig> ParseInputConfigurationAsync(CreateConsoleAppCo
                 creatorConfig.PreferredApis = configuration.PreferredAPIsForDeployment.Split(",");
             }
 
+            //if parameterizeNamedValuesAndSecrets passed as parameter
+            if (!string.IsNullOrEmpty(configuration.ParameterizeNamedValues))
+            {
+                creatorConfig.parameterizeNamedValues = true;
+            }
+
             //if backendurlfile passed as parameter
             if (configuration.BackendUrlConfigFile != null && !string.IsNullOrEmpty(configuration.BackendUrlConfigFile))
             {
@@ -85,6 +92,11 @@ public async Task<CreatorConfig> ParseInputConfigurationAsync(CreateConsoleAppCo
 
         public async Task ExecuteCommandAsync(CreatorConfig creatorConfig)
         {
+            if (!Directory.Exists(creatorConfig.outputLocation))
+            {
+                Directory.CreateDirectory(creatorConfig.outputLocation);
+            }
+
             FileReader fileReader = new FileReader();
 
             // initialize file helper classes

src/ArmTemplates/Commands/Configurations/CreateConsoleAppConfiguration.cs

@@ -32,5 +32,8 @@ public class CreateConsoleAppConfiguration
 
         [Option(longName: "preferredAPIsForDeployment", HelpText = "Create ARM templates for the given APIs Name(comma separated) else leave this parameter blank then by default all api's will be considered")]
         public string PreferredAPIsForDeployment { get; set; }
+
+        [Option(longName: "parameterizeNamedValuesAndSecrets", HelpText = "Allows Creator to parameterize NamedValues and KeyVault Secrets. Output ARM Template then can be deployed to multiple environments")]
+        public string ParameterizeNamedValues { get; set; }
     }
 }

src/ArmTemplates/Creator/Models/CreatorConfiguration.cs

@@ -45,6 +45,8 @@ public class CreatorConfig
         public string linkedTemplatesBaseUrl { get; set; }
         public string linkedTemplatesUrlQueryString { get; set; }
         public string baseFileName { get; set; }
+
+        public bool parameterizeNamedValues { get; set; }
         public List<ServiceUrlProperty> serviceUrlParameters { get; set; }
     }
 

src/ArmTemplates/Creator/TemplateCreators/PropertyTemplateCreator.cs

@@ -1,5 +1,7 @@
 using System.Collections.Generic;
+using System.Linq;
 using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common.Constants;
+using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common.Extensions;
 using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common.TemplateModels;
 using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common.Templates.Abstractions;
 using Microsoft.Azure.Management.ApiManagement.ArmTemplates.Common.Templates.Builders.Abstractions;
@@ -27,9 +29,35 @@ public Template CreatePropertyTemplate(CreatorConfig creatorConfig)
                 { ParameterNames.ApimServiceName, new TemplateParameterProperties(){ type = "string" } }
             };
 
+            if (creatorConfig.parameterizeNamedValues)
+            {
+                if (creatorConfig.namedValues.Any(x => x.value != null))
+                {
+                    propertyTemplate.Parameters.Add(ParameterNames.NamedValues, new TemplateParameterProperties { type = "object" });
+                }
+
+                if (creatorConfig.namedValues.Any(x => x.keyVault != null))
+                {
+                    propertyTemplate.Parameters.Add(ParameterNames.NamedValueKeyVaultSecrets, new TemplateParameterProperties { type = "object" });
+                }
+            }
+
             List<TemplateResource> resources = new List<TemplateResource>();
             foreach (PropertyConfig namedValue in creatorConfig.namedValues)
             {
+                string value = namedValue.value == null ? null
+                   : creatorConfig.parameterizeNamedValues
+                       ? $"[parameters('{ParameterNames.NamedValues}').{ParameterNamingHelper.GenerateValidParameterName(namedValue.displayName, ParameterPrefix.Property)}]"
+                       : namedValue.value;
+
+                PropertyResourceKeyVaultProperties keyVault = namedValue.keyVault == null ? null
+                    : creatorConfig.parameterizeNamedValues
+                        ? new PropertyResourceKeyVaultProperties
+                        {
+                            secretIdentifier = $"[parameters('{ParameterNames.NamedValueKeyVaultSecrets}').{ParameterNamingHelper.GenerateValidParameterName(namedValue.displayName, ParameterPrefix.Property)}]"
+                        }
+                        : namedValue.keyVault;
+
                 // create property resource with properties
                 PropertyTemplateResource propertyTemplateResource = new PropertyTemplateResource()
                 {
@@ -39,10 +67,10 @@ public Template CreatePropertyTemplate(CreatorConfig creatorConfig)
                     Properties = new PropertyResourceProperties()
                     {
                         displayName = namedValue.displayName,
-                        value = namedValue.value,
+                        value = value,
                         secret = namedValue.secret,
                         tags = namedValue.tags,
-                        keyVault = namedValue.keyVault
+                        keyVault = keyVault
 
                     },
                     DependsOn = new string[] { }

src/ArmTemplates/Properties/launchSettings.json

@@ -1,8 +1,7 @@
 {
   "profiles": {
     "apimtemplate": {
-      "commandName": "Project",
-      "commandLineArgs": "extract --extractorConfig C:\\Projects\\other\\extractorConfig.json"
+      "commandName": "Project"
     }
   }
 }

src/README.md

@@ -346,6 +346,7 @@ Below are the steps to run the Creator from the source code:
 ```dotnet run create --configFile CONFIG_YAML_FILE_LOCATION --namedValues namedvalue1|namevaluevalue1;namedvalue2|namevaluevalue2 ```
 Add new key to namedValues section in valid yaml file then use the same key name here in this cli parameter
     **Here displayName can not have | or ; in their name.**
+- Run the following command `dotnet run create --configFile CONFIG_YAML_FILE_LOCATION --parameterizeNamedValuesAndSecrets " "` to parameterize namedValues and KeyVault Secrets and allow to use single ARM template for multiple environments
 
 You can also run it directly from the [releases](https://github.com/Azure/azure-api-management-devops-resource-kit/releases).