Remove dependsOn property from apiTags template (#754)

Co-authored-by: Farhad Alizada <falizada@microsoft.com>

Author: f-alizada

src/ArmTemplates/Extractor/EntityExtractors/TagAPIExtractor.cs

@@ -50,7 +50,7 @@ public async Task<Template<TagApiTemplateResources>> GenerateApiTagsTemplateAsyn
 
             if (!string.IsNullOrEmpty(singleApiName))
             {
-                tagApiTemplate.TypedResources = await this.GenerateSingleApiTagResourceAsync(singleApiName, extractorParameters, Array.Empty<string>());
+                tagApiTemplate.TypedResources = await this.GenerateSingleApiTagResourceAsync(singleApiName, extractorParameters);
             }
             else if (!multipleApiNames.IsNullOrEmpty())
             {
@@ -73,40 +73,31 @@ async Task<TagApiTemplateResources> GenerateMultipleApisTemplateAsync(List<strin
             this.logger.LogDebug("Processing {0} api-names...", multipleApiNames.Count);
 
             var overallResources = new TagApiTemplateResources();
-            string[] dependsOn = Array.Empty<string>();
             foreach (string apiName in multipleApiNames)
             {
-                var tagApiResources = await this.GenerateSingleApiTagResourceAsync(apiName, extractorParameters, dependsOn);
+                var tagApiResources = await this.GenerateSingleApiTagResourceAsync(apiName, extractorParameters);
 
                 if (tagApiResources.HasContent())
                 {
                     overallResources.AddDataResources(tagApiResources);
-
-                    // Extract the tag name from the last resource
-                    string[] lastTagName = tagApiResources.Tags.Last().Name.Replace("')]", "").Split('/');
-                    dependsOn = new string[] { $"[resourceId('Microsoft.ApiManagement/service/apis/tags', parameters('{ParameterNames.ApimServiceName}'), '{apiName}', '{lastTagName[2]}')]" };
                 }
             }
 
             return overallResources;
         }
 
-        async Task<TagApiTemplateResources> GenerateSingleApiTagResourceAsync(string apiName, ExtractorParameters extractorParameters, string[] dependsOn)
+        async Task<TagApiTemplateResources> GenerateSingleApiTagResourceAsync(string apiName, ExtractorParameters extractorParameters)
         {
             var templateResources = new TagApiTemplateResources();
 
             var apiTags = await this.tagClient.GetAllTagsLinkedToApiAsync(apiName, extractorParameters);
-            var dependencyChain = dependsOn;
             foreach (var apiTag in apiTags)
             {
                 var apiTagOriginalName = apiTag.Name;
 
                 apiTag.Name = $"[concat(parameters('{ParameterNames.ApimServiceName}'), '/{apiName}/{apiTagOriginalName}')]";
                 apiTag.ApiVersion = GlobalConstants.ApiVersion;
                 apiTag.Scale = null;
-                apiTag.DependsOn = dependencyChain;
-                dependencyChain = new string[] { $"[resourceId('Microsoft.ApiManagement/service/apis/tags', parameters('{ParameterNames.ApimServiceName}'), '{apiName}', '{apiTagOriginalName}')]" };
-
                 templateResources.Tags.Add(apiTag);
             }
 

tests/ArmTemplates.Tests/Extractor/Scenarios/TagApiExtractorTests.cs

@@ -72,7 +72,7 @@ public async Task GenerateTagApiTemplates_ProperlyLaysTheInformation()
             resources.Tags.Any(x => x.Name.Contains(MockTagClient.TagName1)).Should().BeTrue();
             resources.Tags.Any(x => x.Name.Contains(MockTagClient.TagName2)).Should().BeTrue();
             resources.Tags.All(x => x.ApiVersion == GlobalConstants.ApiVersion).Should().BeTrue();
-            resources.Tags.All(x => !x.DependsOn.IsNullOrEmpty() && !string.IsNullOrEmpty(x.DependsOn.First())).Should().BeTrue();
+            resources.Tags.All(x => x.DependsOn.IsNullOrEmpty()).Should().BeTrue();
         }
     }
 }