Fix revision is current bug (#535)

RupengLiu · web-flow · commit 23d693bae459 · 2021-06-29T21:09:00.000-07:00
* Fix revision is current bug

* Fix test
diff --git a/src/APIM_ARMTemplate/apimtemplate.test/Creator/TemplateCreatorTests/APITemplateCreatorTests.cs b/src/APIM_ARMTemplate/apimtemplate.test/Creator/TemplateCreatorTests/APITemplateCreatorTests.cs
@@ -280,7 +280,7 @@ public async void ShouldAppendRevisionToAPIName()
             {
                 name = "name",
                 apiRevision = "2",
-                isCurrent = true,
+                isCurrent = false,
                 suffix = "suffix",
                 subscriptionRequired = true,
                 openApiSpec = "https://petstore.swagger.io/v2/swagger.json",
diff --git a/src/APIM_ARMTemplate/apimtemplate/Creator/TemplateCreators/APITemplateCreator.cs b/src/APIM_ARMTemplate/apimtemplate/Creator/TemplateCreators/APITemplateCreator.cs
@@ -36,7 +36,7 @@ public async Task<List<Template>> CreateAPITemplatesAsync(APIConfig api)
             int revisionNumber = 0;
             if (Int32.TryParse(api.apiRevision, out revisionNumber))
             {
-                if (revisionNumber > 1 && api.isCurrent == true)
+                if (revisionNumber > 1 && api.isCurrent == false)
                 {
                     string currentAPIName = api.name;
                     api.name += $";rev={revisionNumber}";

Original file line number	Diff line number	Diff line change
`@@ -280,7 +280,7 @@ public async void ShouldAppendRevisionToAPIName()`
`280`	`280`	`{`
`281`	`281`	`name = "name",`
`282`	`282`	`apiRevision = "2",`
`283`		`- isCurrent = true,`
	`283`	`+ isCurrent = false,`
`284`	`284`	`suffix = "suffix",`
`285`	`285`	`subscriptionRequired = true,`
`286`	`286`	`openApiSpec = "https://petstore.swagger.io/v2/swagger.json",`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public async Task<List<Template>> CreateAPITemplatesAsync(APIConfig api)`
`36`	`36`	`int revisionNumber = 0;`
`37`	`37`	`if (Int32.TryParse(api.apiRevision, out revisionNumber))`
`38`	`38`	`{`
`39`		`- if (revisionNumber > 1 && api.isCurrent == true)`
	`39`	`+ if (revisionNumber > 1 && api.isCurrent == false)`
`40`	`40`	`{`
`41`	`41`	`string currentAPIName = api.name;`
`42`	`42`	`api.name += $";rev={revisionNumber}";`