Skip to content

Commit 193f5f2

Browse files
committed
Default values
1 parent f34e6c2 commit 193f5f2

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

src/backend/fastapi_app/dependencies.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,34 +37,35 @@ class FastAPIAppContext(BaseModel):
3737
async def common_parameters():
3838
"""
3939
Get the common parameters for the FastAPI app
40+
Use the pattern of `os.getenv("VAR_NAME") or "default_value"` to avoid empty string values
4041
"""
4142
OPENAI_EMBED_HOST = os.getenv("OPENAI_EMBED_HOST")
4243
OPENAI_CHAT_HOST = os.getenv("OPENAI_CHAT_HOST")
4344
if OPENAI_EMBED_HOST == "azure":
44-
openai_embed_deployment = os.getenv("AZURE_OPENAI_EMBED_DEPLOYMENT", "text-embedding-ada-002")
45-
openai_embed_model = os.getenv("AZURE_OPENAI_EMBED_MODEL", "text-embedding-ada-002")
46-
openai_embed_dimensions = int(os.getenv("AZURE_OPENAI_EMBED_DIMENSIONS", 1536))
47-
embedding_column = os.getenv("AZURE_OPENAI_EMBEDDING_COLUMN", "embedding_ada002")
45+
openai_embed_deployment = os.getenv("AZURE_OPENAI_EMBED_DEPLOYMENT") or "text-embedding-ada-002"
46+
openai_embed_model = os.getenv("AZURE_OPENAI_EMBED_MODEL") or "text-embedding-ada-002"
47+
openai_embed_dimensions = int(os.getenv("AZURE_OPENAI_EMBED_DIMENSIONS") or 1536)
48+
embedding_column = os.getenv("AZURE_OPENAI_EMBEDDING_COLUMN") or "embedding_ada002"
4849
elif OPENAI_EMBED_HOST == "ollama":
4950
openai_embed_deployment = None
50-
openai_embed_model = os.getenv("OLLAMA_EMBED_MODEL", "nomic-embed-text")
51+
openai_embed_model = os.getenv("OLLAMA_EMBED_MODEL") or "nomic-embed-text"
5152
openai_embed_dimensions = None
52-
embedding_column = os.getenv("OLLAMA_EMBEDDING_COLUMN", "embedding_nomic")
53+
embedding_column = os.getenv("OLLAMA_EMBEDDING_COLUMN") or "embedding_nomic"
5354
else:
5455
openai_embed_deployment = None
55-
openai_embed_model = os.getenv("OPENAICOM_EMBED_MODEL", "text-embedding-ada-002")
56+
openai_embed_model = os.getenv("OPENAICOM_EMBED_MODEL") or "text-embedding-ada-002"
5657
openai_embed_dimensions = int(os.getenv("OPENAICOM_EMBED_DIMENSIONS", 1536))
57-
embedding_column = os.getenv("OPENAICOM_EMBEDDING_COLUMN", "embedding_ada002")
58+
embedding_column = os.getenv("OPENAICOM_EMBEDDING_COLUMN") or "embedding_ada002"
5859
if OPENAI_CHAT_HOST == "azure":
59-
openai_chat_deployment = os.getenv("AZURE_OPENAI_CHAT_DEPLOYMENT", "gpt-4o-mini")
60-
openai_chat_model = os.getenv("AZURE_OPENAI_CHAT_MODEL", "gpt-4o-mini")
60+
openai_chat_deployment = os.getenv("AZURE_OPENAI_CHAT_DEPLOYMENT") or "gpt-4o-mini"
61+
openai_chat_model = os.getenv("AZURE_OPENAI_CHAT_MODEL") or "gpt-4o-mini"
6162
elif OPENAI_CHAT_HOST == "ollama":
6263
openai_chat_deployment = None
63-
openai_chat_model = os.getenv("OLLAMA_CHAT_MODEL", "phi3:3.8b")
64-
openai_embed_model = os.getenv("OLLAMA_EMBED_MODEL", "nomic-embed-text")
64+
openai_chat_model = os.getenv("OLLAMA_CHAT_MODEL") or "phi3:3.8b"
65+
openai_embed_model = os.getenv("OLLAMA_EMBED_MODEL") or "nomic-embed-text"
6566
else:
6667
openai_chat_deployment = None
67-
openai_chat_model = os.getenv("OPENAICOM_CHAT_MODEL", "gpt-3.5-turbo")
68+
openai_chat_model = os.getenv("OPENAICOM_CHAT_MODEL") or "gpt-3.5-turbo"
6869
return FastAPIAppContext(
6970
openai_chat_model=openai_chat_model,
7071
openai_embed_model=openai_embed_model,

0 commit comments

Comments
 (0)