From 429475eb085593a7df019bceb5bf977dee572d74 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 21 May 2025 05:57:31 +0000 Subject: [PATCH 1/3] Initial plan for issue From abde02ee3a3087ac52dca525fd385e40e71c77bb Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 21 May 2025 06:00:49 +0000 Subject: [PATCH 2/3] Remove principalId parameter from bicep files Co-authored-by: achandmsft <14188700+achandmsft@users.noreply.github.com> --- infra/main.bicep | 4 ---- infra/main.parameters.json | 3 --- infra/resources.bicep | 3 --- 3 files changed, 10 deletions(-) diff --git a/infra/main.bicep b/infra/main.bicep index 82cd40d..d16a76c 100644 --- a/infra/main.bicep +++ b/infra/main.bicep @@ -12,9 +12,6 @@ param location string param mcpTodoServerAppExists bool param mcpTodoClientAppExists bool -@description('Id of the user or app to assign application roles') -param principalId string - @description('Whether to use the built-in login feature for the application or not') param useLogin bool = true @@ -48,7 +45,6 @@ module resources 'resources.bicep' = { environmentName: environmentName location: location tags: tags - principalId: principalId mcpTodoServerAppExists: mcpTodoServerAppExists mcpTodoClientAppExists: mcpTodoClientAppExists useLogin: useLogin diff --git a/infra/main.parameters.json b/infra/main.parameters.json index 634e757..58c62f8 100644 --- a/infra/main.parameters.json +++ b/infra/main.parameters.json @@ -14,9 +14,6 @@ "mcpTodoServerAppExists": { "value": "${SERVICE_MCPTODO_SERVERAPP_RESOURCE_EXISTS=false}" }, - "principalId": { - "value": "${AZURE_PRINCIPAL_ID}" - }, "useLogin": { "value": "${USE_LOGIN=true}" }, diff --git a/infra/resources.bicep b/infra/resources.bicep index 1ebd717..ff47149 100644 --- a/infra/resources.bicep +++ b/infra/resources.bicep @@ -10,9 +10,6 @@ param tags object = {} param mcpTodoClientAppExists bool param mcpTodoServerAppExists bool -@description('Id of the user or app to assign application roles') -param principalId string - @description('Whether to use the built-in login feature for the application or not') param useLogin bool = true From 3bdb14489adb471a9c9e5436171031548a31ff0d Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 21 May 2025 06:27:06 +0000 Subject: [PATCH 3/3] Revert principalId parameter removal from main.parameters.json Co-authored-by: achandmsft <14188700+achandmsft@users.noreply.github.com> --- infra/main.parameters.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/infra/main.parameters.json b/infra/main.parameters.json index 58c62f8..634e757 100644 --- a/infra/main.parameters.json +++ b/infra/main.parameters.json @@ -14,6 +14,9 @@ "mcpTodoServerAppExists": { "value": "${SERVICE_MCPTODO_SERVERAPP_RESOURCE_EXISTS=false}" }, + "principalId": { + "value": "${AZURE_PRINCIPAL_ID}" + }, "useLogin": { "value": "${USE_LOGIN=true}" },