refactor the integration tests to return the expect the new message when some entity not found

Author: AymaneTech

pom.xml

@@ -11,7 +11,7 @@
     <groupId>com.wora</groupId>
     <artifactId>state-of-dev</artifactId>
     <version>0.0.1-SNAPSHOT</version>
-    <name>state-of-dev</name>
+    <name>IT Survey</name>
     <description>State of dev like</description>
     <url/>
     <licenses>

src/test/java/com/wora/state_of_dev/ModularityTests.java

@@ -0,0 +1,14 @@
+package com.wora.state_of_dev;
+
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
+public class ModularityTests {
+//    ApplicationModules modules = ApplicationModules.of(Application.class);
+//
+//    @Test
+//    @DisplayName("test the application modularity")
+//    void modulesShouldBeDefined() {
+//        modules.verify();
+//    }
+}

src/test/java/com/wora/state_of_dev/survey/infrastructure/web/ChapterControllerIntegrationTest.java

@@ -84,9 +84,9 @@ void givenCorrectRequestAndInvalidSurveyEditionId_whenCreate_shouldReturnNotFoun
             mockMvc.perform(post("/api/v1/chapters" )
                             .contentType(MediaType.APPLICATION_JSON_VALUE)
                             .content(objectMapper.writeValueAsString(request)))
-                    .andExpect(status().isNotFound())
-                    .andExpect(jsonPath("$.code").value(404))
-                    .andExpect(jsonPath("$.message").value(ENTITY_NOT_FOUND_MESSAGE))
+                    .andExpect(status().isBadRequest())
+                    .andExpect(jsonPath("$.code").value(400))
+                    .andExpect(jsonPath("$.message").value(VALIDATION_FAILED_MESSAGE))
                     .andDo(print());
         }
 

src/test/java/com/wora/state_of_dev/survey/infrastructure/web/QuestionControllerIntegrationTest.java

@@ -111,15 +111,15 @@ void givenExistentQuestionId_whenFindById_shouldReturnFoundQuestion() throws Exc
     class CreateTests {
         @Test
         @Rollback
-        void givenChapterIdDoesNotExists_whenCreate_shouldReturnNotFound() throws Exception {
+        void givenChapterIdDoesNotExists_whenCreate_shouldReturnBadRequest() throws Exception {
             QuestionRequestDto invalidRequest = new QuestionRequestDto("your stack", 3939L, AnswerType.SINGLE_CHOICE, answerRequestDtos);
 
             mockMvc.perform(post("/api/v1/questions")
                             .contentType(MediaType.APPLICATION_JSON_VALUE)
                             .content(objectMapper.writeValueAsString(invalidRequest)))
-                    .andExpect(status().isNotFound())
-                    .andExpect(jsonPath("$.message").value(ENTITY_NOT_FOUND_MESSAGE))
-                    .andExpect(jsonPath("$.code").value(404));
+                    .andExpect(status().isBadRequest())
+                    .andExpect(jsonPath("$.message").value(VALIDATION_FAILED_MESSAGE))
+                    .andExpect(jsonPath("$.code").value(400));
         }
 
         @Test
@@ -186,9 +186,9 @@ void givenChapterIdDoesNotExists_whenUpdate_shouldReturnNotFound() throws Except
             mockMvc.perform(put("/api/v1/questions/{id}", question.id())
                             .contentType(MediaType.APPLICATION_JSON_VALUE)
                             .content(objectMapper.writeValueAsString(invalidRequest)))
-                    .andExpect(status().isNotFound())
-                    .andExpect(jsonPath("$.message").value(ENTITY_NOT_FOUND_MESSAGE))
-                    .andExpect(jsonPath("$.code").value(404));
+                    .andExpect(status().isBadRequest())
+                    .andExpect(jsonPath("$.message").value(VALIDATION_FAILED_MESSAGE))
+                    .andExpect(jsonPath("$.code").value(400));
         }
 
         @Test

src/test/java/com/wora/state_of_dev/survey/infrastructure/web/SurveyEditionControllerIntegrationTest.java

@@ -104,15 +104,15 @@ void givenInvalidRequest_whenCreate_shouldReturnBadRequest() throws Exception {
 
         @Test
         @Rollback
-        void givenNotExistentSurveyId_whenCreate_shouldReturnNotFound() throws Exception {
+        void givenNotExistentSurveyId_whenCreate_shouldReturnBadRequest() throws Exception {
             SurveyEditionRequestDto invalidRequest = new SurveyEditionRequestDto(LocalDateTime.now().plusDays(1), LocalDateTime.now().plusDays(39), Year.now(), 9393L);
 
             mockMvc.perform(post("/api/v1/survey-editions")
                             .contentType(MediaType.APPLICATION_JSON_VALUE)
                             .content(objectMapper.writeValueAsString(invalidRequest)))
-                    .andExpect(status().isNotFound())
-                    .andExpect(jsonPath("$.code").value(404))
-                    .andExpect(jsonPath("$.message").value(ENTITY_NOT_FOUND_MESSAGE));
+                    .andExpect(status().isBadRequest())
+                    .andExpect(jsonPath("$.code").value(400))
+                    .andExpect(jsonPath("$.message").value(VALIDATION_FAILED_MESSAGE));
         }
 
         @Test
@@ -151,9 +151,9 @@ void givenNotExistentSurveyId_whenUpdate_shouldReturnNotFound() throws Exception
             mockMvc.perform(put("/api/v1/survey-editions/{id}", 9999L)
                             .contentType(MediaType.APPLICATION_JSON_VALUE)
                             .content(objectMapper.writeValueAsString(validRequest)))
-                    .andExpect(status().isNotFound())
-                    .andExpect(jsonPath("$.code").value(404))
-                    .andExpect(jsonPath("$.message").value(ENTITY_NOT_FOUND_MESSAGE));
+                    .andExpect(status().isBadRequest())
+                    .andExpect(jsonPath("$.code").value(400))
+                    .andExpect(jsonPath("$.message").value(VALIDATION_FAILED_MESSAGE));
         }
 
         @Test