diff --git a/protobuf/avs.pb.go b/protobuf/avs.pb.go index 47fbeefc..d08367ba 100644 --- a/protobuf/avs.pb.go +++ b/protobuf/avs.pb.go @@ -1203,7 +1203,8 @@ type FilterNode struct { // Filter node acts like .select or .filter to pluck out element in an array that evaluate the expression to true Expression string `protobuf:"bytes,1,opt,name=expression,proto3" json:"expression,omitempty"` - // input is the id of the node that + // input is the id of the node that we will fetch its value from and feed into the iteration. + // this input has to be an array. Currently we only know about the error at runtime Input string `protobuf:"bytes,2,opt,name=input,proto3" json:"input,omitempty"` } @@ -4324,7 +4325,7 @@ var file_protobuf_avs_proto_rawDesc = []byte{ 0x0a, 0x0a, 0x06, 0x51, 0x75, 0x65, 0x75, 0x65, 0x64, 0x10, 0x00, 0x12, 0x0c, 0x0a, 0x08, 0x46, 0x69, 0x6e, 0x69, 0x73, 0x68, 0x65, 0x64, 0x10, 0x02, 0x2a, 0x20, 0x0a, 0x0e, 0x43, 0x75, 0x73, 0x74, 0x6f, 0x6d, 0x43, 0x6f, 0x64, 0x65, 0x4c, 0x61, 0x6e, 0x67, 0x12, 0x0e, 0x0a, 0x0a, 0x4a, - 0x61, 0x76, 0x61, 0x53, 0x63, 0x72, 0x69, 0x70, 0x74, 0x10, 0x00, 0x32, 0xba, 0x09, 0x0a, 0x0a, + 0x61, 0x76, 0x61, 0x53, 0x63, 0x72, 0x69, 0x70, 0x74, 0x10, 0x00, 0x32, 0xc0, 0x09, 0x0a, 0x0a, 0x41, 0x67, 0x67, 0x72, 0x65, 0x67, 0x61, 0x74, 0x6f, 0x72, 0x12, 0x36, 0x0a, 0x06, 0x47, 0x65, 0x74, 0x4b, 0x65, 0x79, 0x12, 0x15, 0x2e, 0x61, 0x67, 0x67, 0x72, 0x65, 0x67, 0x61, 0x74, 0x6f, 0x72, 0x2e, 0x47, 0x65, 0x74, 0x4b, 0x65, 0x79, 0x52, 0x65, 0x71, 0x1a, 0x13, 0x2e, 0x61, 0x67, @@ -4386,22 +4387,23 @@ var file_protobuf_avs_proto_rawDesc = []byte{ 0x2e, 0x43, 0x72, 0x65, 0x61, 0x74, 0x65, 0x4f, 0x72, 0x55, 0x70, 0x64, 0x61, 0x74, 0x65, 0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x52, 0x65, 0x71, 0x1a, 0x1a, 0x2e, 0x67, 0x6f, 0x6f, 0x67, 0x6c, 0x65, 0x2e, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x62, 0x75, 0x66, 0x2e, 0x42, 0x6f, 0x6f, 0x6c, 0x56, - 0x61, 0x6c, 0x75, 0x65, 0x22, 0x00, 0x12, 0x43, 0x0a, 0x06, 0x44, 0x65, 0x6c, 0x65, 0x74, 0x65, - 0x12, 0x1b, 0x2e, 0x61, 0x67, 0x67, 0x72, 0x65, 0x67, 0x61, 0x74, 0x6f, 0x72, 0x2e, 0x44, 0x65, - 0x6c, 0x65, 0x74, 0x65, 0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x52, 0x65, 0x71, 0x1a, 0x1a, 0x2e, - 0x67, 0x6f, 0x6f, 0x67, 0x6c, 0x65, 0x2e, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x62, 0x75, 0x66, 0x2e, - 0x42, 0x6f, 0x6f, 0x6c, 0x56, 0x61, 0x6c, 0x75, 0x65, 0x22, 0x00, 0x12, 0x48, 0x0a, 0x0b, 0x4c, - 0x69, 0x73, 0x74, 0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x73, 0x12, 0x1a, 0x2e, 0x61, 0x67, 0x67, - 0x72, 0x65, 0x67, 0x61, 0x74, 0x6f, 0x72, 0x2e, 0x4c, 0x69, 0x73, 0x74, 0x53, 0x65, 0x63, 0x72, - 0x65, 0x74, 0x73, 0x52, 0x65, 0x71, 0x1a, 0x1b, 0x2e, 0x61, 0x67, 0x67, 0x72, 0x65, 0x67, 0x61, - 0x74, 0x6f, 0x72, 0x2e, 0x4c, 0x69, 0x73, 0x74, 0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x73, 0x52, - 0x65, 0x73, 0x70, 0x22, 0x00, 0x12, 0x51, 0x0a, 0x0c, 0x55, 0x70, 0x64, 0x61, 0x74, 0x65, 0x53, - 0x65, 0x63, 0x72, 0x65, 0x74, 0x12, 0x23, 0x2e, 0x61, 0x67, 0x67, 0x72, 0x65, 0x67, 0x61, 0x74, - 0x6f, 0x72, 0x2e, 0x43, 0x72, 0x65, 0x61, 0x74, 0x65, 0x4f, 0x72, 0x55, 0x70, 0x64, 0x61, 0x74, - 0x65, 0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x52, 0x65, 0x71, 0x1a, 0x1a, 0x2e, 0x67, 0x6f, 0x6f, - 0x67, 0x6c, 0x65, 0x2e, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x62, 0x75, 0x66, 0x2e, 0x42, 0x6f, 0x6f, - 0x6c, 0x56, 0x61, 0x6c, 0x75, 0x65, 0x22, 0x00, 0x42, 0x0c, 0x5a, 0x0a, 0x2e, 0x2f, 0x61, 0x76, - 0x73, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x62, 0x06, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x33, + 0x61, 0x6c, 0x75, 0x65, 0x22, 0x00, 0x12, 0x49, 0x0a, 0x0c, 0x44, 0x65, 0x6c, 0x65, 0x74, 0x65, + 0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x12, 0x1b, 0x2e, 0x61, 0x67, 0x67, 0x72, 0x65, 0x67, 0x61, + 0x74, 0x6f, 0x72, 0x2e, 0x44, 0x65, 0x6c, 0x65, 0x74, 0x65, 0x53, 0x65, 0x63, 0x72, 0x65, 0x74, + 0x52, 0x65, 0x71, 0x1a, 0x1a, 0x2e, 0x67, 0x6f, 0x6f, 0x67, 0x6c, 0x65, 0x2e, 0x70, 0x72, 0x6f, + 0x74, 0x6f, 0x62, 0x75, 0x66, 0x2e, 0x42, 0x6f, 0x6f, 0x6c, 0x56, 0x61, 0x6c, 0x75, 0x65, 0x22, + 0x00, 0x12, 0x48, 0x0a, 0x0b, 0x4c, 0x69, 0x73, 0x74, 0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x73, + 0x12, 0x1a, 0x2e, 0x61, 0x67, 0x67, 0x72, 0x65, 0x67, 0x61, 0x74, 0x6f, 0x72, 0x2e, 0x4c, 0x69, + 0x73, 0x74, 0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x73, 0x52, 0x65, 0x71, 0x1a, 0x1b, 0x2e, 0x61, + 0x67, 0x67, 0x72, 0x65, 0x67, 0x61, 0x74, 0x6f, 0x72, 0x2e, 0x4c, 0x69, 0x73, 0x74, 0x53, 0x65, + 0x63, 0x72, 0x65, 0x74, 0x73, 0x52, 0x65, 0x73, 0x70, 0x22, 0x00, 0x12, 0x51, 0x0a, 0x0c, 0x55, + 0x70, 0x64, 0x61, 0x74, 0x65, 0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x12, 0x23, 0x2e, 0x61, 0x67, + 0x67, 0x72, 0x65, 0x67, 0x61, 0x74, 0x6f, 0x72, 0x2e, 0x43, 0x72, 0x65, 0x61, 0x74, 0x65, 0x4f, + 0x72, 0x55, 0x70, 0x64, 0x61, 0x74, 0x65, 0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x52, 0x65, 0x71, + 0x1a, 0x1a, 0x2e, 0x67, 0x6f, 0x6f, 0x67, 0x6c, 0x65, 0x2e, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x62, + 0x75, 0x66, 0x2e, 0x42, 0x6f, 0x6f, 0x6c, 0x56, 0x61, 0x6c, 0x75, 0x65, 0x22, 0x00, 0x42, 0x0c, + 0x5a, 0x0a, 0x2e, 0x2f, 0x61, 0x76, 0x73, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x62, 0x06, 0x70, 0x72, + 0x6f, 0x74, 0x6f, 0x33, } var ( @@ -4537,7 +4539,7 @@ var file_protobuf_avs_proto_depIdxs = []int32{ 5, // 56: aggregator.Aggregator.DeleteTask:input_type -> aggregator.IdReq 43, // 57: aggregator.Aggregator.TriggerTask:input_type -> aggregator.UserTriggerTaskReq 45, // 58: aggregator.Aggregator.CreateSecret:input_type -> aggregator.CreateOrUpdateSecretReq - 48, // 59: aggregator.Aggregator.Delete:input_type -> aggregator.DeleteSecretReq + 48, // 59: aggregator.Aggregator.DeleteSecret:input_type -> aggregator.DeleteSecretReq 46, // 60: aggregator.Aggregator.ListSecrets:input_type -> aggregator.ListSecretsReq 45, // 61: aggregator.Aggregator.UpdateSecret:input_type -> aggregator.CreateOrUpdateSecretReq 39, // 62: aggregator.Aggregator.GetKey:output_type -> aggregator.KeyResp @@ -4554,7 +4556,7 @@ var file_protobuf_avs_proto_depIdxs = []int32{ 56, // 73: aggregator.Aggregator.DeleteTask:output_type -> google.protobuf.BoolValue 44, // 74: aggregator.Aggregator.TriggerTask:output_type -> aggregator.UserTriggerTaskResp 56, // 75: aggregator.Aggregator.CreateSecret:output_type -> google.protobuf.BoolValue - 56, // 76: aggregator.Aggregator.Delete:output_type -> google.protobuf.BoolValue + 56, // 76: aggregator.Aggregator.DeleteSecret:output_type -> google.protobuf.BoolValue 47, // 77: aggregator.Aggregator.ListSecrets:output_type -> aggregator.ListSecretsResp 56, // 78: aggregator.Aggregator.UpdateSecret:output_type -> google.protobuf.BoolValue 62, // [62:79] is the sub-list for method output_type diff --git a/protobuf/avs.proto b/protobuf/avs.proto index c3a2332a..752dbd93 100644 --- a/protobuf/avs.proto +++ b/protobuf/avs.proto @@ -175,7 +175,8 @@ message BranchNode { message FilterNode { // Filter node acts like .select or .filter to pluck out element in an array that evaluate the expression to true string expression = 1; - // input is the id of the node that + // input is the id of the node that we will fetch its value from and feed into the iteration. + // this input has to be an array. Currently we only know about the error at runtime string input = 2; } @@ -544,7 +545,7 @@ service Aggregator { // You can decide whether to grant secret to a single workflow or many workflow, or all of your workflow // By default, your secret is available across all of your tasks. rpc CreateSecret(CreateOrUpdateSecretReq) returns (google.protobuf.BoolValue) {}; - rpc Delete(DeleteSecretReq) returns (google.protobuf.BoolValue) {}; + rpc DeleteSecret(DeleteSecretReq) returns (google.protobuf.BoolValue) {}; // Return all secrets belong to this user. Currently we don't support any fine tune or filter yet. // Only secret names and config data are returned. The secret value aren't returned. diff --git a/protobuf/avs_grpc.pb.go b/protobuf/avs_grpc.pb.go index 63e649d5..d3f32077 100644 --- a/protobuf/avs_grpc.pb.go +++ b/protobuf/avs_grpc.pb.go @@ -43,7 +43,7 @@ type AggregatorClient interface { // You can decide whether to grant secret to a single workflow or many workflow, or all of your workflow // By default, your secret is available across all of your tasks. CreateSecret(ctx context.Context, in *CreateOrUpdateSecretReq, opts ...grpc.CallOption) (*wrapperspb.BoolValue, error) - Delete(ctx context.Context, in *DeleteSecretReq, opts ...grpc.CallOption) (*wrapperspb.BoolValue, error) + DeleteSecret(ctx context.Context, in *DeleteSecretReq, opts ...grpc.CallOption) (*wrapperspb.BoolValue, error) // Return all secrets belong to this user. Currently we don't support any fine tune or filter yet. // Only secret names and config data are returned. The secret value aren't returned. ListSecrets(ctx context.Context, in *ListSecretsReq, opts ...grpc.CallOption) (*ListSecretsResp, error) @@ -186,9 +186,9 @@ func (c *aggregatorClient) CreateSecret(ctx context.Context, in *CreateOrUpdateS return out, nil } -func (c *aggregatorClient) Delete(ctx context.Context, in *DeleteSecretReq, opts ...grpc.CallOption) (*wrapperspb.BoolValue, error) { +func (c *aggregatorClient) DeleteSecret(ctx context.Context, in *DeleteSecretReq, opts ...grpc.CallOption) (*wrapperspb.BoolValue, error) { out := new(wrapperspb.BoolValue) - err := c.cc.Invoke(ctx, "/aggregator.Aggregator/Delete", in, out, opts...) + err := c.cc.Invoke(ctx, "/aggregator.Aggregator/DeleteSecret", in, out, opts...) if err != nil { return nil, err } @@ -237,7 +237,7 @@ type AggregatorServer interface { // You can decide whether to grant secret to a single workflow or many workflow, or all of your workflow // By default, your secret is available across all of your tasks. CreateSecret(context.Context, *CreateOrUpdateSecretReq) (*wrapperspb.BoolValue, error) - Delete(context.Context, *DeleteSecretReq) (*wrapperspb.BoolValue, error) + DeleteSecret(context.Context, *DeleteSecretReq) (*wrapperspb.BoolValue, error) // Return all secrets belong to this user. Currently we don't support any fine tune or filter yet. // Only secret names and config data are returned. The secret value aren't returned. ListSecrets(context.Context, *ListSecretsReq) (*ListSecretsResp, error) @@ -293,8 +293,8 @@ func (UnimplementedAggregatorServer) TriggerTask(context.Context, *UserTriggerTa func (UnimplementedAggregatorServer) CreateSecret(context.Context, *CreateOrUpdateSecretReq) (*wrapperspb.BoolValue, error) { return nil, status.Errorf(codes.Unimplemented, "method CreateSecret not implemented") } -func (UnimplementedAggregatorServer) Delete(context.Context, *DeleteSecretReq) (*wrapperspb.BoolValue, error) { - return nil, status.Errorf(codes.Unimplemented, "method Delete not implemented") +func (UnimplementedAggregatorServer) DeleteSecret(context.Context, *DeleteSecretReq) (*wrapperspb.BoolValue, error) { + return nil, status.Errorf(codes.Unimplemented, "method DeleteSecret not implemented") } func (UnimplementedAggregatorServer) ListSecrets(context.Context, *ListSecretsReq) (*ListSecretsResp, error) { return nil, status.Errorf(codes.Unimplemented, "method ListSecrets not implemented") @@ -567,20 +567,20 @@ func _Aggregator_CreateSecret_Handler(srv interface{}, ctx context.Context, dec return interceptor(ctx, in, info, handler) } -func _Aggregator_Delete_Handler(srv interface{}, ctx context.Context, dec func(interface{}) error, interceptor grpc.UnaryServerInterceptor) (interface{}, error) { +func _Aggregator_DeleteSecret_Handler(srv interface{}, ctx context.Context, dec func(interface{}) error, interceptor grpc.UnaryServerInterceptor) (interface{}, error) { in := new(DeleteSecretReq) if err := dec(in); err != nil { return nil, err } if interceptor == nil { - return srv.(AggregatorServer).Delete(ctx, in) + return srv.(AggregatorServer).DeleteSecret(ctx, in) } info := &grpc.UnaryServerInfo{ Server: srv, - FullMethod: "/aggregator.Aggregator/Delete", + FullMethod: "/aggregator.Aggregator/DeleteSecret", } handler := func(ctx context.Context, req interface{}) (interface{}, error) { - return srv.(AggregatorServer).Delete(ctx, req.(*DeleteSecretReq)) + return srv.(AggregatorServer).DeleteSecret(ctx, req.(*DeleteSecretReq)) } return interceptor(ctx, in, info, handler) } @@ -685,8 +685,8 @@ var Aggregator_ServiceDesc = grpc.ServiceDesc{ Handler: _Aggregator_CreateSecret_Handler, }, { - MethodName: "Delete", - Handler: _Aggregator_Delete_Handler, + MethodName: "DeleteSecret", + Handler: _Aggregator_DeleteSecret_Handler, }, { MethodName: "ListSecrets",