Skip to content

Commit d350679

Browse files
committed
types(model+query): correctly remove count from TypeScript types to reflect removal of runtime support
Fix #14062
1 parent 1bfcdf6 commit d350679

File tree

3 files changed

+1
-19
lines changed

3 files changed

+1
-19
lines changed

test/types/queries.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ Test.find({}, {}, { populate: { path: 'child', model: ChildModel, match: true }
7272

7373
Test.find().byName('test').byName('test2').orFail().exec().then(console.log);
7474

75-
Test.count({ name: /Test/ }).exec().then((res: number) => console.log(res));
75+
Test.countDocuments({ name: /Test/ }).exec().then((res: number) => console.log(res));
7676
Test.findOne({ 'docs.id': 42 }).exec().then(console.log);
7777

7878
// ObjectId casting

types/models.d.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -201,15 +201,6 @@ declare module 'mongoose' {
201201
/** Collection the model uses. */
202202
collection: Collection;
203203

204-
/** Creates a `count` query: counts the number of documents that match `filter`. */
205-
count(filter?: FilterQuery<TRawDocType>): QueryWithHelpers<
206-
number,
207-
THydratedDocumentType,
208-
TQueryHelpers,
209-
TRawDocType,
210-
'count'
211-
>;
212-
213204
/** Creates a `countDocuments` query: counts the number of documents that match `filter`. */
214205
countDocuments(
215206
filter?: FilterQuery<TRawDocType>,

types/query.d.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -259,15 +259,6 @@ declare module 'mongoose' {
259259
/** Specifies the `comment` option. */
260260
comment(val: string): this;
261261

262-
/** Specifies this query as a `count` query. */
263-
count(criteria?: FilterQuery<DocType>): QueryWithHelpers<
264-
number,
265-
DocType,
266-
THelpers,
267-
RawDocType,
268-
'count'
269-
>;
270-
271262
/** Specifies this query as a `countDocuments` query. */
272263
countDocuments(
273264
criteria?: FilterQuery<DocType>,

0 commit comments

Comments
 (0)